Re: [Openvpn-devel] [PATCH applied] Re: Remove extra token after #endif

2018-11-22 Thread David Sommerseth
On 21/11/2018 10:34, Gert Doering wrote: > > Regarding Christian's comment about "#endif" vs. "#endif /* ENABLE_CRYPTO /*" > - well, we have both in our tree, so neither is "correct" or "wrong". > > For such a short #ifdef/#endif span, I'd see it as optional because the > corresponding #ifdef is

[Openvpn-devel] [PATCH applied] Re: Remove extra token after #endif

2018-11-21 Thread Gert Doering
Acked-by: Gert Doering Thanks. Regarding Christian's comment about "#endif" vs. "#endif /* ENABLE_CRYPTO /*" - well, we have both in our tree, so neither is "correct" or "wrong". For such a short #ifdef/#endif span, I'd see it as optional because the corresponding #ifdef is easily spotted. For