On 21/11/2018 10:34, Gert Doering wrote: > > Regarding Christian's comment about "#endif" vs. "#endif /* ENABLE_CRYPTO /*" > - well, we have both in our tree, so neither is "correct" or "wrong". > > For such a short #ifdef/#endif span, I'd see it as optional because the > corresponding #ifdef is easily spotted. For something spanning more > code, possibly nested #ifdef, a comment after the #endif would definitely > be better, though.
Just FTR; I share this point of view. We've not been too picky about these #endif remarks in the past but something we saw more of after the big reformatting commit right before the v2.4.0 release. We used these uncrustify settings for the great reformatting patch: ------------------- # Annotate #else and #endif statements mod_add_long_ifdef_endif_comment=20 mod_add_long_ifdef_else_comment=5 ------------------- -- kind regards, David Sommerseth OpenVPN Inc
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
