Re: [Openvpn-devel] [PATCH 2/8] implement networking API for iproute2

2018-04-20 Thread Antonio Quartulli
Hi, there is one little "open" thing in this patch that I wanted to highlight. See below: On 20/04/18 19:16, Antonio Quartulli wrote: > +static struct env_set *es = NULL; > + . > +openvpn_execve_check(&argv, es, S_FATAL, "Linux ip link set failed"); Right now the code initializing the e

[Openvpn-devel] [PATCH 2/8] implement networking API for iproute2

2018-04-20 Thread Antonio Quartulli
iproute2 is the first user of the new networking API and its one of the two currently supported functionalities on Linux (the other being net-tools). This patch simply copies the current code from tun.c/route.c to networking_ip.c without introducing any funcional change to the code. Signed-off-by