Hi, there is one little "open" thing in this patch that I wanted to highlight. See below:
On 20/04/18 19:16, Antonio Quartulli wrote: > +static struct env_set *es = NULL; > + ..... > + openvpn_execve_check(&argv, es, S_FATAL, "Linux ip link set failed"); Right now the code initializing the environment set to be passed to openvpn_execve() with NULL. This means that not ENV is passed to the iproute commands. This behaviour does not reflect the original one as in the current code we always pass the complete ENV coming from the openvpn context. This begs two questions: 1) how can we pass the env_set without making the API dependent on that? (this is really just an iproute thing, unlreated to the networking side of things) 2) do we really need to pass the entire ENV to iproute commands? I understand it is needed for the scripts, but why passing it to these commands too? Shouldn't we expect them to work by using only the commandline arguments? Cheers, -- Antonio Quartulli
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
