Re: [Openvpn-devel] [PATCH 2/2] Make most registry values optional

2018-02-27 Thread Selva Nair
Hi, On Wed, Feb 21, 2018 at 2:42 AM, Gert Doering wrote: > Hi, > > On Tue, Feb 20, 2018 at 06:33:35PM -0500, Selva Nair wrote: >> > (It does happen for my own binary and for the installers Samuli builds, >> > so it's not "my build environment" - theoretically it could be part 1/2 >> > of that pat

Re: [Openvpn-devel] [PATCH 2/2] Make most registry values optional

2018-02-27 Thread Gert Doering
Hi, On Tue, Feb 20, 2018 at 06:33:35PM -0500, Selva Nair wrote: > > (It does happen for my own binary and for the installers Samuli builds, > > so it's not "my build environment" - theoretically it could be part 1/2 > > of that patch set, which I haven't run yet) > > Yeah, I could reproduce it on

Re: [Openvpn-devel] [PATCH 2/2] Make most registry values optional

2018-02-27 Thread Selva Nair
Hi, On Wed, Feb 21, 2018 at 8:20 AM, Selva Nair wrote: > Hi, > > On Wed, Feb 21, 2018 at 2:42 AM, Gert Doering wrote: >> Hi, >> >> On Tue, Feb 20, 2018 at 06:33:35PM -0500, Selva Nair wrote: >>> > (It does happen for my own binary and for the installers Samuli builds, >>> > so it's not "my build

Re: [Openvpn-devel] [PATCH 2/2] Make most registry values optional

2018-02-27 Thread Gert Doering
Hi, On Wed, Feb 21, 2018 at 08:20:34AM -0500, Selva Nair wrote: > > Thanks for investigating and finding the root cause. "This is not what > > the documentation says...!" -> I need to actually *run* these things, not > > just test compile. > > When I say painful builds, I mean edit build[*], cop

Re: [Openvpn-devel] [PATCH 2/2] Make most registry values optional

2018-02-27 Thread Gert Doering
Hi, On Tue, Feb 20, 2018 at 11:19:23AM -0500, Selva Nair wrote: > Hmm.. I thought I had tested the patch.. Looking at it right now -- hold on :) Missed you on IRC... 18:21 < selvanair> cron2: iservives in 2.4 local build and snapshot build works on Windows 10. Have to go now,

Re: [Openvpn-devel] [PATCH 2/2] Make most registry values optional

2018-02-27 Thread Selva Nair
Hi, On Tue, Feb 20, 2018 at 2:59 PM, Gert Doering wrote: > Hi, > > On Tue, Feb 20, 2018 at 11:19:23AM -0500, Selva Nair wrote: >> Hmm.. I thought I had tested the patch.. Looking at it right now -- hold on >> :) > > Missed you on IRC... > > 18:21 < selvanair> cron2: iservives in 2.4 local build

Re: [Openvpn-devel] [PATCH 2/2] Make most registry values optional

2018-02-21 Thread Gert Doering
Hi, well, today is the day that I get to break things, it seems... On Sat, Nov 18, 2017 at 12:40:58PM -0500, selva.n...@gmail.com wrote: > +/* The default value of REG_KEY is the install path */ > +if (GetRegString(key, NULL, install_path, sizeof(install_path), NULL) != > ERROR_SUCCESS)

Re: [Openvpn-devel] [PATCH 2/2] Make most registry values optional

2018-02-20 Thread Selva Nair
Hi, On Tue, Feb 20, 2018 at 11:14 AM, Gert Doering wrote: > Hi, > > well, today is the day that I get to break things, it seems... > > On Sat, Nov 18, 2017 at 12:40:58PM -0500, selva.n...@gmail.com wrote: >> +/* The default value of REG_KEY is the install path */ >> +if (GetRegString(key,

[Openvpn-devel] [PATCH 2/2] Make most registry values optional

2017-11-18 Thread selva . nair
From: Selva Nair Not all installations need registry values such as log_dir and config_dir especially if automatic service is not in use. This patch provides reasonable defaults for registry values. - Read the default value of HKLM\Software\PACKAGE_NAME to get the install path and construct de