Hi, On Wed, Feb 21, 2018 at 8:20 AM, Selva Nair <selva.n...@gmail.com> wrote: > Hi, > > On Wed, Feb 21, 2018 at 2:42 AM, Gert Doering <g...@greenie.muc.de> wrote: >> Hi, >> >> On Tue, Feb 20, 2018 at 06:33:35PM -0500, Selva Nair wrote: >>> > (It does happen for my own binary and for the installers Samuli builds, >>> > so it's not "my build environment" - theoretically it could be part 1/2 >>> > of that patch set, which I haven't run yet) >>> >>> Yeah, I could reproduce it on Windows 7. And, at last, after several >>> painful Windows builds, it turns out: >>> >>> RegGetValue with RRF_RT_REG_EXPAND_SZ|RRF_RT_REG_SZ is broken on >>> Windows 7 (and most likely Vista too). >> >> Thanks for investigating and finding the root cause. "This is not what >> the documentation says...!" -> I need to actually *run* these things, not >> just test compile. > > When I say painful builds, I mean edit build[*], copy to Windows, run > in a few configurations, look through the event viewer, rinse rather > repeat. And finally when it seems to start working connect to a my > work VPN, remove the registry keys and try to break it etc.. > > FYI, I don't just "test compile", and leave it at that.
On re-reading, it sounds different from what I wanted to say. I was just cursing stupid Windows that's no fun to debug on... In this particular case it was my fault that I never tested the patch on Windows 7 in the first place. I used to run a Win7 VM, but now all my desktop memory is eaten by those 50 chrome tabs.. Anyway, sorry to all (and to myself) for causing a "must-fix" bug close to a release. Selva ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
