Re: [Openvpn-devel] [PATCH] build: rename bool->obool

2012-03-28 Thread Alon Bar-Lev
On Wed, Mar 28, 2012 at 11:45 AM, David Sommerseth wrote: > The reason for that review is that I'm not convinced adding our own > boolean type is the way to go.  I'd much rather see us using stdbool.h > and keep using the bool for pure boolean purposes.  Where flags needs to > be used, it makes mu

Re: [Openvpn-devel] [PATCH] build: rename bool->obool

2012-03-28 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 28/03/12 11:32, Alon Bar-Lev wrote: > On Sat, Mar 24, 2012 at 9:21 PM, Alon Bar-Lev > wrote: >> On Sat, Mar 24, 2012 at 9:15 PM, Alon Bar-Lev >> wrote: >>> PPC architectures and conflict with stdbool.h. >>> >>> basic.h defines a type 'bool' that

Re: [Openvpn-devel] [PATCH] build: rename bool->obool

2012-03-28 Thread Alon Bar-Lev
On Sat, Mar 24, 2012 at 9:21 PM, Alon Bar-Lev wrote: > On Sat, Mar 24, 2012 at 9:15 PM, Alon Bar-Lev wrote: >> PPC architectures and conflict with stdbool.h. >> >> basic.h defines a type 'bool' that conflicts with the altivec >> keyword bool which has to be fixed upstream, see bugs[1][2]. >> >> [

Re: [Openvpn-devel] [PATCH] build: rename bool->obool

2012-03-25 Thread Alon Bar-Lev
On Sat, Mar 24, 2012 at 9:21 PM, Alon Bar-Lev wrote: > On Sat, Mar 24, 2012 at 9:15 PM, Alon Bar-Lev wrote: >> PPC architectures and conflict with stdbool.h. >> >> basic.h defines a type 'bool' that conflicts with the altivec >> keyword bool which has to be fixed upstream, see bugs[1][2]. >> >> [

Re: [Openvpn-devel] [PATCH] build: rename bool->obool

2012-03-25 Thread Alon Bar-Lev
On Sun, Mar 25, 2012 at 1:12 PM, Gert Doering wrote: > Personally I think that this is a regression in GCC, and we should NOT > do anything about it.  If the compiler is documented to have a new > data type "bool__", it should not mess with "bool", which is a different > name by all means - bad en

Re: [Openvpn-devel] [PATCH] build: rename bool->obool

2012-03-25 Thread Gert Doering
Hi, On Sun, Mar 25, 2012 at 01:10:45PM +0200, Alon Bar-Lev wrote: > However the flags modifications from [1] should be merged anyway, I > will submit a patch. > > What do you think? > > Thanks, > Alon. > > [1] https://297854.bugs.gentoo.org/attachment.cgi?id=214304 I strongly support that. Th

Re: [Openvpn-devel] [PATCH] build: rename bool->obool

2012-03-25 Thread Gert Doering
Hi, On Sun, Mar 25, 2012 at 12:51:55PM +0200, Fabian Knittel wrote: > 2012/3/24 Alon Bar-Lev : > > On Sat, Mar 24, 2012 at 9:15 PM, Alon Bar-Lev wrote: > >> PPC architectures and conflict with stdbool.h. > >> > >> basic.h defines a type 'bool' that conflicts with the altivec > >> keyword bool whi

Re: [Openvpn-devel] [PATCH] build: rename bool->obool

2012-03-25 Thread Alon Bar-Lev
On Sun, Mar 25, 2012 at 12:51 PM, Fabian Knittel wrote: > > Hi Alon, > > 2012/3/24 Alon Bar-Lev : > > On Sat, Mar 24, 2012 at 9:15 PM, Alon Bar-Lev > > wrote: > >> PPC architectures and conflict with stdbool.h. > >> > >> basic.h defines a type 'bool' that conflicts with the altivec > >> keyword b

Re: [Openvpn-devel] [PATCH] build: rename bool->obool

2012-03-25 Thread Fabian Knittel
Hi Alon, 2012/3/24 Alon Bar-Lev : > On Sat, Mar 24, 2012 at 9:15 PM, Alon Bar-Lev wrote: >> PPC architectures and conflict with stdbool.h. >> >> basic.h defines a type 'bool' that conflicts with the altivec >> keyword bool which has to be fixed upstream, see bugs[1][2]. >> >> [1] https://bugs.gen

Re: [Openvpn-devel] [PATCH] build: rename bool->obool

2012-03-24 Thread Alon Bar-Lev
On Sat, Mar 24, 2012 at 9:15 PM, Alon Bar-Lev wrote: > PPC architectures and conflict with stdbool.h. > > basic.h defines a type 'bool' that conflicts with the altivec > keyword bool which has to be fixed upstream, see bugs[1][2]. > > [1] https://bugs.gentoo.org/show_bug.cgi?id=293840 > [2] https: