Hi, Lev
Thanks for review, I'll make improvements in V2.
--
Best Regards, Vladislav Grishenko
-Original Message-
From: Lev Stipakov
Sent: Wednesday, August 5, 2020 1:29 PM
To: Vladislav Grishenko
Cc: openvpn-devel
Subject: Re: [Openvpn-devel] [PATCH] Log serial number of re
Hi,
Compiled and tested on Ubuntu 20.04, looks good.
A few nit-picks:
> +verify_check_crl_dir(const char *crl_dir, int cert_depth,
> openvpn_x509_cert_t *cert, char *subject)
The last parameter could benefit from const to indicate that function
is not going to modify it.
> -msg(D_HAN
As it appears commit 767e4c56becbfeea525e4695a810593f373883cd "Log
serial number of revoked certificate" hasn't survive refactoring
of CRL handling.
In most of situations admin of OpenVPN server needs to know which
particular certificate is used by client.
In the case when certificate is valid, en
