Re: [Openvpn-devel] [PATCH] FQDN for routes should expand to all IPs (second round)

2010-03-01 Thread Karl O. Pinc
On 03/01/2010 08:12:03 AM, Stefan Monnier wrote: > >> If someone could give at least some vaguely plausible scenario, > >> that'd help. > > Maybe there's more than one tunnel and there's some stupid > > load balancing going on using a hosts file? (Along with > > deleting all non-vpn routes.) > >

Re: [Openvpn-devel] [PATCH] FQDN for routes should expand to all IPs (second round)

2010-03-01 Thread Stefan Monnier
>> If someone could give at least some vaguely plausible scenario, >> that'd help. > Maybe there's more than one tunnel and there's some stupid > load balancing going on using a hosts file? (Along with > deleting all non-vpn routes.) [ Setting aside the fact that using OpenVPN's broken handling o

Re: [Openvpn-devel] [PATCH] FQDN for routes should expand to all IPs (second round)

2010-03-01 Thread Karl O. Pinc
On 02/28/2010 02:04:01 PM, Stefan Monnier wrote: > > I'm at a loss when it comes to try and imagine someone who's used to > the > current behavior and bothered by the new behavior. Really. How can > the > current behavior ever be preferable? Why would someone ever prefer > that > a route would

Re: [Openvpn-devel] [PATCH] FQDN for routes should expand to all IPs (second round)

2010-02-28 Thread Stefan Monnier
> I was doing some considerations back and forth here before starting this > second round. The issue is that it changes the behaviour quite a lot > from what might be expected from earlier versions (if you're used to the > former behaviour). I'm at a loss when it comes to try and imagine someone

Re: [Openvpn-devel] [PATCH] FQDN for routes should expand to all IPs (second round)

2010-02-28 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 27/02/10 00:27, Stefan Monnier wrote: >> - From the following review discussion, a few other things needs to be >> changed and I hope you are willing to look into adopting your patch to >> those guidelines. This is also to follow the standards [1]

Re: [Openvpn-devel] [PATCH] FQDN for routes should expand to all IPs (second round)

2010-02-26 Thread Stefan Monnier
> - From the following review discussion, a few other things needs to be > changed and I hope you are willing to look into adopting your patch to > those guidelines. This is also to follow the standards [1] we try to > introduce as well. Sure, I'd like to get this in the main OpenVPN code, so I'l

[Openvpn-devel] [PATCH] FQDN for routes should expand to all IPs (second round)

2010-02-26 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 (resent - to get it into the mailing list) Hi Stefan! I believe you've noticed we've included a patch which aims to remove the randomisation I found when reviewing your patch. - From the following review discussion, a few other things needs to be ch