-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 (resent - to get it into the mailing list)
Hi Stefan! I believe you've noticed we've included a patch which aims to remove the randomisation I found when reviewing your patch. - From the following review discussion, a few other things needs to be changed and I hope you are willing to look into adopting your patch to those guidelines. This is also to follow the standards [1] we try to introduce as well. So, to give a summary to what needs to be done: * This feature should be #ifdef'ed, so that it can be disabled for those not wanting this feature. * MAX_IPS_PER_HOSTNAME should be set via ./configure. I'd probably recommend that if this value is 0 the feature is not enabled (covers the first point automatically and simplifies ./configure) If f.ex. only - --enable-resolve-all-ips (probably need a better targeted name) is given without a number, the default should be 20. * Implement this patch on top of the frp branch, and make sure you add the possibility to disable the randomisation of resolving. I hope I haven't forgotten or overseen anything now. Would you be willing to do this job? When these things are covered, I believe the patch has reached a state where it is suitable for inclusion. kind regards, David Sommerseth [1] <http://www.secure-computing.net/wiki/index.php/OpenVPN/Developer_documentation> -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkuIEQsACgkQDC186MBRfroqKQCfZGkkMtIUDkIIkXYXXLirOlts nBcAn2nIn+xsVu/9Fz7AOlzEgQPohETw =SE/7 -----END PGP SIGNATURE-----
