Re: [Openvpn-devel] [PATCH] Add 'localhost' token to client-nat network option

2025-02-24 Thread Frank Lichtenheld
On Sun, Feb 23, 2025 at 03:26:36PM -0300, Rafael Gava wrote: > Hi Frank, > > Thank you for your feedback. I'll make the changes as per your suggestions > and resubmit the patch later. My apologies for not realizing that you were > using a formatting check tool. I installed Uncrustify, and it worke

Re: [Openvpn-devel] [PATCH] Add 'localhost' token to client-nat network option

2025-02-24 Thread Arne Schwabe
Am 23.02.25 um 20:05 schrieb Rafael Gava: Hi Arne, Thank you for your feedback. I agree with your suggestion and will replace the localhost token with 'assigned-ip' before resubmitting the patch. Regarding your question about testing P2P, I haven't tested it yet. Do you happen to have a con

Re: [Openvpn-devel] [PATCH] Add 'localhost' token to client-nat network option

2025-02-23 Thread Rafael Gava
Hi Arne, Thank you for your feedback. I agree with your suggestion and will replace the localhost token with 'assigned-ip' before resubmitting the patch. Regarding your question about testing P2P, I haven't tested it yet. Do you happen to have a configuration I could use for this scenario? Best

Re: [Openvpn-devel] [PATCH] Add 'localhost' token to client-nat network option

2025-02-23 Thread Rafael Gava
Hi Frank, Thank you for your feedback. I'll make the changes as per your suggestions and resubmit the patch later. My apologies for not realizing that you were using a formatting check tool. I installed Uncrustify, and it worked perfectly. :-) I also wanted to ask about the automated tests on Git

Re: [Openvpn-devel] [PATCH] Add 'localhost' token to client-nat network option

2025-02-21 Thread Antonio Quartulli
On 21/02/2025 12:58, Frank Lichtenheld wrote: On Thu, Feb 20, 2025 at 04:48:27PM -0300, Rafael Gava wrote: +bool +update_localhost_nat(struct client_nat_option_list *dest, in_addr_t local_ip) +{ +int i; +bool ret = false; + +if (!dest) { Also, the opening '{' should go on its own l

Re: [Openvpn-devel] [PATCH] Add 'localhost' token to client-nat network option

2025-02-21 Thread Arne Schwabe
Am 20.02.25 um 20:48 schrieb Rafael Gava: Dear OpenVPN Community, I am submitting this patch to introduce a 'localhost' token to the `client-nat` network option, allowing OpenVPN clients to dynamically use the IP address provided by the server. This enhancement is particularly useful in scena

Re: [Openvpn-devel] [PATCH] Add 'localhost' token to client-nat network option

2025-02-21 Thread Frank Lichtenheld
On Thu, Feb 20, 2025 at 04:48:27PM -0300, Rafael Gava wrote: > I believe this feature will be beneficial for many OpenVPN users, improving > automation and simplifying VPN gateway configurations. Please find the > patch inline for review and feedback. > Thanks for your submission. Some general no

[Openvpn-devel] [PATCH] Add 'localhost' token to client-nat network option

2025-02-20 Thread Rafael Gava
Dear OpenVPN Community, I am submitting this patch to introduce a 'localhost' token to the `client-nat` network option, allowing OpenVPN clients to dynamically use the IP address provided by the server. This enhancement is particularly useful in scenarios where OpenVPN is deployed as a VPN gateway