On Sun, Feb 23, 2025 at 03:26:36PM -0300, Rafael Gava wrote: > Hi Frank, > > Thank you for your feedback. I'll make the changes as per your suggestions > and resubmit the patch later. My apologies for not realizing that you were > using a formatting check tool. I installed Uncrustify, and it worked > perfectly. :-) > > I also wanted to ask about the automated tests on GitHub. Should I fork the > project and submit the patch there, or should I submit it directly to the > main project? What is the recommended approach?
If you want to use Github, then fork the repository. Note that we do not merge Github PRs directly. Actual patch approval only happens in Gerrit or here on the list (see also https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation#PatchsubmissionviaGerrit). So using Github is not required, but it allows you to use the Github actions basically instantly to get some cross-platform verification of your work. Regards, -- Frank Lichtenheld _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
