Re: [Openvpn-devel] [Feedback needed] Fix cross compile support

Hi, On Sun, Mar 14, 2010 at 12:26:58PM +0100, Matthias Andree wrote: > > ... and this is exactly what I proposed: don't include the larger chunk > > of the changes right *now*. Wait for the multiple branches to settle > > down, and then decide how to adjust the TARGET_* definitions. > > Which is

Re: [Openvpn-devel] [Feedback needed] Fix cross compile support

Am 14.03.2010, 12:19 Uhr, schrieb Gert Doering : Hi, On Sun, Mar 14, 2010 at 12:13:26AM +0100, Matthias Andree wrote: No offense, but do you think it's within objective discussion to call the patch "mostly-religious change" (which is a non-objective comment in my book) if you "don't really

Re: [Openvpn-devel] [Feedback needed] Fix cross compile support

Hi, On Sun, Mar 14, 2010 at 12:13:26AM +0100, Matthias Andree wrote: > No offense, but do you think it's within objective discussion to call the > patch > "mostly-religious change" (which is a non-objective comment in my book) if you > "don't really understand the subtleties of autoconf and frien

Re: [Openvpn-devel] [Feedback needed] Fix cross compile support

Am 01.03.2010 11:58, schrieb Gert Doering: > Hi, > > On Sun, Feb 28, 2010 at 10:25:10PM +0100, David Sommerseth wrote: >> I'm reviewing this patch in the patch tracker, and cannot make up my >> mind if this is correct or not. Can someone please advise if this is >> something we should include or

Re: [Openvpn-devel] [Feedback needed] Fix cross compile support

Hi, On Sun, Feb 28, 2010 at 10:25:10PM +0100, David Sommerseth wrote: > I'm reviewing this patch in the patch tracker, and cannot make up my > mind if this is correct or not. Can someone please advise if this is > something we should include or not? > >

Re: [Openvpn-devel] [Feedback needed] Fix cross compile support

Yes, it is better than current. Should use --host= and not --target= for cross compile. 1. I would not touch host_alias it is irrelevant and may lead to problems. Use only host variable in autoconf. 2. The case in autoconf should be '*-*-os*)' and not '*os*)' 3. I don't think it is so important

[Openvpn-devel] [Feedback needed] Fix cross compile support

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I'm reviewing this patch in the patch tracker, and cannot make up my mind if this is correct or not. Can someone please advise if this is something we should include or not?