Hi,
On Sun, Mar 14, 2010 at 12:13:26AM +0100, Matthias Andree wrote:
> No offense, but do you think it's within objective discussion to call the
> patch
> "mostly-religious change" (which is a non-objective comment in my book) if you
> "don't really understand the subtleties of autoconf and friends"?
Well, there's two parts to the original patch.
One is the functional patches in configure.ac - I can't say anything about
that, so I'm not doing so.
The other part is changing all TARGET_* defines to HOST_* defines. This
is not changing functionality or portability, as the very defines are
explicitely set in configure.ac, and they could be MySystemIs_* as far as
functionality is concerned. So the change is because people believe it
to be "the right way" - which makes it "mostly-religious" in my book: not
based on functional changes, but because "it's the right way".
Whitespace changes to cleanup broken formatting fall into the same category
for me - quite often, there are very good reasons to do so, but if the
circumstances are such that it conflicts with other development work, it
might be prudent to postpone them until after other stuff has been merged.
... and this is exactly what I proposed: don't include the larger chunk
of the changes right *now*. Wait for the multiple branches to settle
down, and then decide how to adjust the TARGET_* definitions.
[..]
> WRT practical merge concerns around TARGET_*, git knows the "rerere"
> sub-command
> to track merge conflict resolutions (see the manual); and since the required
> edits can be scripted, that could happen on the feature branches before
> attempting a merge. No big deal.
Well, this is putting extra work on David Sommerseth's lap. If he is willing
to handle that, I won't object.
As for now, I have been operating under the premises that different branches
in the openvpn-devel tree should avoid to cause merge conflicts (unless
unavoidable for required functionality, see ipv6 payload vs. ipv6 transport).
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
