[Openvpn-devel] [S] Change in openvpn[release/2.6]: dco linux: avoid redefining ovpn enums (2.6)

2025-08-01 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos, ralf_lici. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1122?usp=email ) Change subject: dco linux: avoid redefining ovpn enums (2.6) ..

[Openvpn-devel] [S] Change in openvpn[release/2.6]: dco linux: avoid redefining ovpn enums (2.6)

2025-07-31 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos, ralf_lici. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1122?usp=email ) Change subject: dco linux: avoid redefining ovpn enums (2.6) ..

[Openvpn-devel] [XS] Change in openvpn[master]: dco: drop client prefix after DCO PEER_FLOAT notification

2025-07-28 Thread ordex (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1116?usp=email ) Change subject: dco: drop client prefix after DCO PEER_FLOAT notification .

[Openvpn-devel] [XS] Change in openvpn[master]: dco: drop client prefix after DCO PEER_FLOAT notification

2025-07-28 Thread ordex (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1116?usp=email ) Change subject: dco: drop client prefix after DCO PEER_FLOAT notification .

[Openvpn-devel] [S] Change in openvpn[master]: mudp.c, multi.c, multi_io.c: get rid of "all three DCO platforms" #if...

2025-07-28 Thread ordex (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1117?usp=email ) Change subject: mudp.c, multi.c, multi_io.c: get rid of "all three DCO platforms" #ifdefs

[Openvpn-devel] [S] Change in openvpn[master]: multi: make some multi_*() functions static

2025-07-25 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1115?usp=email to look at the new patch set (#2). Change subject: multi: make some multi_*() functions stati

[Openvpn-devel] [XS] Change in openvpn[master]: dco: drop client prefix after DCO PEER_FLOAT notification

2025-07-25 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1116?usp=email to review the following change. Change subject: dco: drop client prefix after DCO PEER_FLOAT no

[Openvpn-devel] [S] Change in openvpn[master]: multi: make multi_process_float() static

2025-07-25 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1115?usp=email to review the following change. Change subject: multi: make multi_process_float() static ..

[Openvpn-devel] [M] Change in openvpn[master]: dco_linux: clean up PEER_GET trigger and parser

2025-07-25 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1114?usp=email to look at the new patch set (#3). Change subject: dco_linux: clean up PEER_GET trigger and p

[Openvpn-devel] [M] Change in openvpn[master]: dco_linux: clean up PEER_GET trigger and parser

2025-07-25 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1114?usp=email to look at the new patch set (#2). Change subject: dco_linux: clean up PEER_GET trigger and p

[Openvpn-devel] [M] Change in openvpn[master]: dco_linux: clean up PEER_GET trigger and parser

2025-07-25 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1114?usp=email to review the following change. Change subject: dco_linux: clean up PEER_GET trigger and parser

[Openvpn-devel] [M] Change in openvpn[master]: dco_linux: fix async message reception

2025-07-23 Thread ordex (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1100?usp=email to look at the new patch set (#5). The following approvals got outdated and were

[Openvpn-devel] [M] Change in openvpn[master]: dco_linux: fix async message reception

2025-07-23 Thread ordex (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1100?usp=email ) Change subject: dco_linux: fix async message reception ..

[Openvpn-devel] [L] Change in openvpn[master]: dco_linux: factor out netlink notification code

2025-07-23 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1099?usp=email to look at the new patch set (#4). Change subject: dco_linux: factor out netlink notification

[Openvpn-devel] [S] Change in openvpn[master]: dco: only pass struct context to init function

2025-07-23 Thread ordex (Code Review)
Attention is currently required from: cron2, flichtenheld, ordex, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1094?usp=email to look at the new patch set (#4). Change subject: dco: only pass struct

[Openvpn-devel] [L] Change in openvpn[master]: dco_linux: factor out netlink notification code

2025-07-23 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1099?usp=email ) Change subject: dco_linux: factor out netlink notification code ..

[Openvpn-devel] [S] Change in openvpn[master]: dco: only pass struct context to init function

2025-07-23 Thread ordex (Code Review)
Attention is currently required from: cron2, flichtenheld, ordex, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1094?usp=email to look at the new patch set (#3). Change subject: dco: only pass struct

[Openvpn-devel] [M] Change in openvpn[master]: dco_linux: fix async message reception

2025-07-23 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1100?usp=email to look at the new patch set (#3). Change subject: dco_linux: fix async message reception ...

[Openvpn-devel] [S] Change in openvpn[master]: multi: store multi_context address inside top instance

2025-07-22 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1093?usp=email to review the following change. Change subject: multi: store multi_context address inside top i

[Openvpn-devel] [XS] Change in openvpn[master]: add context to dco-linux.h

2025-07-22 Thread ordex (Code Review)
ordex has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/1097?usp=email ) Change subject: add context to dco-linux.h .. Abandoned this was supposed to be merged with another commit -- To view, visit http://gerr

[Openvpn-devel] [S] Change in openvpn[master]: dco: only pass struct context to init function

2025-07-22 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1094?usp=email to look at the new patch set (#2). Change subject: dco: only pass struct context to init func

[Openvpn-devel] [S] Change in openvpn[master]: dco: only pass struct context to init function

2025-07-22 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1094?usp=email to review the following change. Change subject: dco: only pass struct context to init function

[Openvpn-devel] [XS] Change in openvpn[master]: dco_linux: fix case statement by using proper error value

2025-07-22 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1095?usp=email to review the following change. Change subject: dco_linux: fix case statement by using proper e

[Openvpn-devel] [S] Change in openvpn[master]: dco_linux: use M_FATAL instead of M_ERR in netlink error code paths

2025-07-22 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1096?usp=email to review the following change. Change subject: dco_linux: use M_FATAL instead of M_ERR in netl

[Openvpn-devel] [XS] Change in openvpn[master]: add context to dco-linux.h

2025-07-22 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1097?usp=email to review the following change. Change subject: add context to dco-linux.h

[Openvpn-devel] [M] Change in openvpn[master]: dco_linux: fix async message reception

2025-07-22 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1100?usp=email to review the following change. Change subject: dco_linux: fix async message reception

[Openvpn-devel] [L] Change in openvpn[master]: dco_linux: factor out netlink notification code

2025-07-22 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1099?usp=email to review the following change. Change subject: dco_linux: factor out netlink notification code

[Openvpn-devel] [L] Change in openvpn[master]: dco_linux: rearrange functions

2025-07-22 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1098?usp=email to review the following change. Change subject: dco_linux: rearrange functions

[Openvpn-devel] [M] Change in openvpn[master]: dco: Add support for float notifications

2025-07-18 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos, ralf_lici, stipa. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1084?usp=email ) Change subject: dco: Add support for float notifications ...

[Openvpn-devel] [S] Change in openvpn[master]: README.dco: update Linux instructions

2025-07-16 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1087?usp=email to look at the new patch set (#3). The following approvals got outdated and were remove

[Openvpn-devel] [S] Change in openvpn[master]: README.dco: update Linux instructions

2025-07-16 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1087?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code

[Openvpn-devel] [S] Change in openvpn[master]: README.dco: update Linux instructions

2025-07-16 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1087?usp=email ) Change subject: README.dco: update Linux instructions .. Patch S

[Openvpn-devel] [S] Change in openvpn[master]: README.dco: update Linux instructions

2025-07-16 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1087?usp=email ) Change subject: README.dco: update Linux instructions .. Patch S

[Openvpn-devel] [S] Change in openvpn[master]: README.dco: update Linux instructions

2025-07-16 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1087?usp=email to review the following change. Change subject: README.dco: update Linux instructions .

[Openvpn-devel] [M] Change in openvpn[master]: dco: Add support for float notifications

2025-07-16 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos, ralf_lici, stipa. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1084?usp=email ) Change subject: dco: Add support for float notifications ...

[Openvpn-devel] [M] Change in openvpn[master]: dco: Add support for float notifications

2025-07-16 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos, ralf_lici. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1084?usp=email ) Change subject: dco: Add support for float notifications ..

[Openvpn-devel] [M] Change in openvpn[master]: dco: Add support for float notifications

2025-07-15 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos, ralf_lici, stipa. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1084?usp=email ) Change subject: dco: Add support for float notifications ...

[Openvpn-devel] [S] Change in openvpn[master]: Fix new doxygen warnings about using @return in void functions

2025-07-02 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1029?usp=email ) Change subject: Fix new doxygen warnings about using @return in void functions ...

[Openvpn-devel] [S] Change in openvpn[master]: Fix new doxygen warnings about using @return in void functions

2025-07-02 Thread ordex (Code Review)
Attention is currently required from: flichtenheld. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1029?usp=email ) Change subject: Fix new doxygen warnings about using @return in void functions ..

[Openvpn-devel] [XS] Change in openvpn[master]: dco linux: avoid sending local port to ovpn

2025-06-25 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos, ralf_lici. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1068?usp=email ) Change subject: dco linux: avoid sending local port to ovpn ...

[Openvpn-devel] [XS] Change in openvpn[master]: dco linux: avoid redefining ovpn enums

2025-06-23 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos, ralf_lici. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1064?usp=email ) Change subject: dco linux: avoid redefining ovpn enums

[Openvpn-devel] [S] Change in openvpn[master]: dco_linux: enable extended netlink error reporting

2025-06-09 Thread ordex (Code Review)
Attention is currently required from: cron2, flichtenheld, ordex, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1040?usp=email to look at the new patch set (#2). The following approvals got outdated a

[Openvpn-devel] [XS] Change in openvpn[master]: dco_linux: enable extended netlink error reporting

2025-06-06 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1040?usp=email to review the following change. Change subject: dco_linux: enable extended netlink error report

[Openvpn-devel] [XS] Change in openvpn[master]: dco_linux: avoid bogus text when netlink message is not parsed

2025-05-23 Thread ordex (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1027?usp=email ) Change subject: dco_linux: avoid bogus text when netlink message is not parsed

[Openvpn-devel] [XS] Change in openvpn[master]: dco_linux: avoid bogus text when netlink message is not parsed

2025-05-23 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1027?usp=email to look at the new patch set (#3). Change subject: dco_linux: avoid bogus text

[Openvpn-devel] [XS] Change in openvpn[master]: dco_linux: avoid bogus text when netlink message is not parsed

2025-05-22 Thread ordex (Code Review)
Attention is currently required from: cron2, flichtenheld, ordex, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1027?usp=email to look at the new patch set (#2). The following approvals got outdated a

[Openvpn-devel] [S] Change in openvpn[master]: dco_linux: print meaningful text when netlink message is not parsed

2025-05-19 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1027?usp=email to review the following change. Change subject: dco_linux: print meaningful text when netlink m

[Openvpn-devel] [S] Change in openvpn[master]: dco_linux: fix peer stats parsing with new ovpn kernel module

2025-05-16 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1025?usp=email to look at the new patch set (#2). Change subject: dco_linux: fix peer stats parsing with new

[Openvpn-devel] [S] Change in openvpn[master]: dco_linux: fix peer stats parsing with new ovpn kernel module

2025-05-16 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1025?usp=email to review the following change. Change subject: dco_linux: fix peer stats parsing with new ovpn

[Openvpn-devel] [M] Change in openvpn[master]: Implement ovpn version detection

2025-05-14 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos, ralf_lici. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1022?usp=email ) Change subject: Implement ovpn version detection .. P

[Openvpn-devel] [L] Change in openvpn[master]: dco_linux: Introduce new uAPIs

2025-04-28 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/941?usp=email ) Change subject: dco_linux: Introduce new uAPIs .. Patc

[Openvpn-devel] [L] Change in openvpn[master]: dco_linux: Introduce new uAPIs

2025-04-24 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, ordex, plaisthos. ordex has uploaded a new patch set (#4) to the change originally created by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/941?usp=email ) Change subject: dco_linux: Introduce new uAPIs

[Openvpn-devel] [L] Change in openvpn[master]: dco_linux: Introduce new uAPIs

2025-04-24 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, ordex, plaisthos. ordex has uploaded a new patch set (#3) to the change originally created by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/941?usp=email ) Change subject: dco_linux: Introduce new uAPIs

[Openvpn-devel] [L] Change in openvpn[master]: Add support to "ovpn" aka "in upstream kernel"

2025-04-19 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/941?usp=email ) Change subject: Add support to "ovpn" aka "in upstream kernel" .

[Openvpn-devel] [XS] Change in openvpn[master]: ssl_openssl.c: Prevent potential double-free

2025-04-17 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/942?usp=email ) Change subject: ssl_openssl.c: Prevent potential double-free ...

[Openvpn-devel] [XS] Change in openvpn[master]: ssl_openssl.c: Prevent potential double-free

2025-04-17 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/942?usp=email ) Change subject: ssl_openssl.c: Prevent potential double-free .. P

[Openvpn-devel] [XS] Change in openvpn[master]: ssl_openssl.c: Prevent potential double-free

2025-04-17 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/942?usp=email ) Change subject: ssl_openssl.c: Prevent potential double-free ...

[Openvpn-devel] [XS] Change in openvpn[master]: ssl_openssl.c: Prevent potential double-free

2025-04-17 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/942?usp=email ) Change subject: ssl_openssl.c: Prevent potential double-free ...

[Openvpn-devel] [L] Change in openvpn[master]: Add support to "ovpn" aka "in upstream kernel"

2025-04-17 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/941?usp=email ) Change subject: Add support to "ovpn" aka "in upstream kernel" .

[Openvpn-devel] [L] Change in openvpn[master]: Add support to "ovpn" aka "in upstream kernel"

2025-04-17 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/941?usp=email ) Change subject: Add support to "ovpn" aka "in upstream kernel" .

[Openvpn-devel] [L] Change in openvpn[master]: Add support to "ovpn" aka "in upstream kernel"

2025-04-17 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/941?usp=email ) Change subject: Add support to "ovpn" aka "in upstream kernel" .

[Openvpn-devel] [L] Change in openvpn[master]: Add support to "ovpn" aka "in upstream kernel"

2025-04-17 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/941?usp=email ) Change subject: Add support to "ovpn" aka "in upstream kernel" .

[Openvpn-devel] [XL] Change in openvpn[master]: Reformat the whole project with clang-format

2025-04-16 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/791?usp=email ) Change subject: Reformat the whole project with clang-format .. P

[Openvpn-devel] [XL] Change in openvpn[master]: Reformat the whole project with clang-format

2025-04-14 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/791?usp=email ) Change subject: Reformat the whole project with clang-format .. P

[Openvpn-devel] [S] Change in openvpn[master]: Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid

2025-04-02 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/927?usp=email ) Change subject: Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid ...

[Openvpn-devel] [S] Change in openvpn[master]: Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid

2025-04-01 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, ordex. ordex has uploaded a new patch set (#4) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/927?usp=email ) Change subject: Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid .

[Openvpn-devel] [S] Change in openvpn[master]: Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid

2025-04-01 Thread ordex (Code Review)
Attention is currently required from: flichtenheld. ordex has uploaded a new patch set (#3) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/927?usp=email ) Change subject: Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid

[Openvpn-devel] [S] Change in openvpn[master]: Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid

2025-04-01 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/927?usp=email ) Change subject: Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid ...

[Openvpn-devel] [XS] Change in openvpn[master]: Fix incorrect condition for checking password related check

2025-03-27 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/912?usp=email ) Change subject: Fix incorrect condition for checking password related check ...

[Openvpn-devel] [S] Change in openvpn[master]: Make 'lport 0' no longer sufficient to do '--bind'.

2025-03-24 Thread ordex (Code Review)
Attention is currently required from: cron2, flichtenheld. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/916?usp=email ) Change subject: Make 'lport 0' no longer sufficient to do '--bind'. ..

[Openvpn-devel] [XS] Change in openvpn[master]: socket: use remote proto when creating client sockets

2025-03-19 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/911?usp=email to review the following change. Change subject: socket: use remote proto when creating client so

[Openvpn-devel] [S] Change in openvpn[master]: socket: don't transfer bind family to socket in case of ANY address

2025-03-17 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/907?usp=email to look at the new patch set (#2). Change subject: socket: don't transfer bind family to socke

[Openvpn-devel] [S] Change in openvpn[master]: socket: don't transfer bind family to socket in case of ANY address

2025-03-17 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/907?usp=email ) Change subject: socket: don't transfer bind family to socket in case of ANY address ..

[Openvpn-devel] [S] Change in openvpn[master]: socket: don't transfer bind family to socket in case of ANY address

2025-03-17 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/907?usp=email ) Change subject: socket: don't transfer bind family to socket in case of ANY address ..

[Openvpn-devel] [S] Change in openvpn[master]: socket: don't transfer bind family to socket in case of ANY address

2025-03-12 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/907?usp=email to review the following change. Change subject: socket: don't transfer bind family to socket in

[Openvpn-devel] [XS] Change in openvpn[master]: dco: pass remoteaddr only for UDP peers

2025-02-21 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/842?usp=email ) Change subject: dco: pass remoteaddr only for UDP peers ..

[Openvpn-devel] [XS] Change in openvpn[master]: dco: pass remoteaddr only for UDP peers

2025-02-21 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos, stipa. Hello flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/842?usp=email to look at the new patch set (#2). The following approvals got outdated an

[Openvpn-devel] [M] Change in openvpn[master]: Implement override-username

2025-02-17 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/872?usp=email ) Change subject: Implement override-username .. Patch Set 5: (1 c

[Openvpn-devel] [XS] Change in openvpn[master]: get_default_gateway(): implement platform support for Linux/SITNL

2025-01-31 Thread ordex (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/883?usp=email ) Change subject: get_default_gateway(): implement platform support for Linux/SITNL .

[Openvpn-devel] [M] Change in openvpn[master]: get_default_gateway(): implement platform support for Linux/IPROUTE2

2025-01-31 Thread ordex (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/884?usp=email ) Change subject: get_default_gateway(): implement platform support for Linux/IPROUTE2 ..

[Openvpn-devel] [XS] Change in openvpn[master]: mudp.c: keep offset value when resetting buffer

2025-01-30 Thread ordex (Code Review)
Attention is currently required from: plaisthos, stipa. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/814?usp=email ) Change subject: mudp.c: keep offset value when resetting buffer .. Patch

[Openvpn-devel] [XS] Change in openvpn[master]: mudp.c: keep offset value when resetting buffer

2025-01-30 Thread ordex (Code Review)
Attention is currently required from: plaisthos, stipa. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/814?usp=email ) Change subject: mudp.c: keep offset value when resetting buffer .. Patch

[Openvpn-devel] [L] Change in openvpn[master]: Add support for simultaneous use of UDP and TCP sockets

2025-01-29 Thread ordex (Code Review)
Attention is currently required from: cron2, its_Giaan, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/764?usp=email ) Change subject: Add support for simultaneous use of UDP and TCP sockets ...

[Openvpn-devel] [S] Change in openvpn[master]: mroute/management: fix unitialized variable (UNINIT)

2025-01-28 Thread ordex (Code Review)
Attention is currently required from: cron2, flichtenheld, its_Giaan, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/880?usp=email ) Change subject: mroute/management: fix unitialized variable (UNINIT)

[Openvpn-devel] [S] Change in openvpn[master]: dco_linux: extend netlink error cb with extra info

2025-01-28 Thread ordex (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/841?usp=email ) Change subject: dco_linux: extend netlink error cb with extra info .

[Openvpn-devel] [S] Change in openvpn[master]: dco_linux: extend netlink error cb with extra info

2025-01-27 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/841?usp=email to look at the new patch set (#9). Change subject: dco_linux: extend netlink err

[Openvpn-devel] [S] Change in openvpn[master]: dco_linux: extend netlink error cb with extra info

2025-01-27 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, ordex. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/841?usp=email to look at the new patch set (#8). Change subject: dco_linux: extend netlink error cb with extra i

[Openvpn-devel] [S] Change in openvpn[master]: dco_linux: extend netlink error cb with extra info

2025-01-27 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, ordex. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/841?usp=email to look at the new patch set (#7). Change subject: dco_linux: extend netlink error cb with extra i

[Openvpn-devel] [S] Change in openvpn[master]: dco_linux: extend netlink error cb with extra info

2025-01-27 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, ordex. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/841?usp=email to look at the new patch set (#6). Change subject: dco_linux: extend netlink error cb with extra i

[Openvpn-devel] [L] Change in openvpn[master]: dco_linux: extend netlink error cb with extra info

2025-01-25 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/841?usp=email to look at the new patch set (#5). Change subject: dco_linux: extend netlink error cb with ext

[Openvpn-devel] [L] Change in openvpn[master]: dco_linux: extend netlink error cb with extra info

2025-01-25 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/841?usp=email to look at the new patch set (#4). Change subject: dco_linux: extend netlink error cb with ext

[Openvpn-devel] [L] Change in openvpn[master]: dco_linux: extend netlink error cb with extra info

2025-01-25 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/841?usp=email to look at the new patch set (#3). Change subject: dco_linux: extend netlink error cb with ext

[Openvpn-devel] [L] Change in openvpn[master]: dco_linux: extend netlink error cb with extra info

2025-01-25 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/841?usp=email to look at the new patch set (#2). Change subject: dco_linux: extend netlink error cb with ext

[Openvpn-devel] [XS] Change in openvpn[master]: man: extend --persist-tun section

2025-01-25 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/819?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed

[Openvpn-devel] [XS] Change in openvpn[master]: man: extend --persist-tun section

2025-01-25 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/819?usp=email ) Change subject: man: extend --persist-tun section .. Patch Set 2:

[Openvpn-devel] [S] Change in openvpn[master]: Fix "uninitialized pointer read" in openvpn_decrypt_aead

2025-01-13 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/858?usp=email ) Change subject: Fix "uninitialized pointer read" in openvpn_decrypt_aead ..

[Openvpn-devel] [S] Change in openvpn[master]: multi.c: add iroutes after dco peer is added

2025-01-13 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/856?usp=email ) Change subject: multi.c: add iroutes after dco peer is added ...

[Openvpn-devel] [M] Change in openvpn[master]: allow user to specify 'local' multiple times in config files

2025-01-08 Thread ordex (Code Review)
Attention is currently required from: cron2, flichtenheld, its_Giaan, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/436?usp=email ) Change subject: allow user to specify 'local' multiple times in config files

[Openvpn-devel] [XS] Change in openvpn[master]: dco: pass remoteaddr only for UDP peers

2024-12-13 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/842?usp=email to review the following change. Change subject: dco: pass remoteaddr only for UDP peers

[Openvpn-devel] [S] Change in openvpn[master]: dco_linux: extend netlink error cb with extra info

2024-12-13 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/841?usp=email ) Change subject: dco_linux: extend netlink error cb with extra info

  1   2   >