[Openvpn-devel] [S] Change in openvpn[release/2.6]: dco linux: avoid redefining ovpn enums (2.6)

2025-08-01 Thread flichtenheld (Code Review)
Attention is currently required from: flichtenheld, plaisthos, ralf_lici. Hello ordex, plaisthos, ralf_lici, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1122?usp=email to look at the new patch set (#2). Change subject: dco linux: avoid redefining

[Openvpn-devel] [S] Change in openvpn[release/2.6]: dco linux: avoid redefining ovpn enums (2.6)

2025-08-01 Thread flichtenheld (Code Review)
Attention is currently required from: ordex, plaisthos, ralf_lici. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1122?usp=email ) Change subject: dco linux: avoid redefining ovpn enums (2.6) ..

[Openvpn-devel] [S] Change in openvpn[master]: Update text of GPL to latest version from FSF

2025-07-31 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1123?usp=email to look at the new patch set (#2). Change subject: Update text of GPL to latest version from FSF

[Openvpn-devel] [S] Change in openvpn[master]: Update text of GPL to latest version from FSF

2025-07-31 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1123?usp=email to review the following change. Change subject: Update text of GPL to latest version from FSF .

[Openvpn-devel] [S] Change in openvpn[release/2.6]: dco linux: avoid redefining ovpn enums (2.6)

2025-07-31 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1122?usp=email to review the following change. Change subject: dco linux: avoid redefining ovpn enums (2.6) ..

[Openvpn-devel] [M] Change in openvpn[master]: list: Make types of hash elements consistent

2025-07-29 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1119?usp=email to review the following change. Change subject: list: Make types of hash elements consistent ..

[Openvpn-devel] [S] Change in openvpn[master]: ssl_common: Make sure ssl flags are treated as unsigned

2025-07-28 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1104?usp=email to look at the new patch set (#2). Change subject: ssl_common: Make sure ssl flags are treated as unsigned ..

[Openvpn-devel] [M] Change in openvpn[master]: options: Simplify function setenv_foreign_option

2025-07-28 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1112?usp=email ) Change subject: options: Simplify function setenv_foreign_option .

[Openvpn-devel] [M] Change in openvpn[master]: options: Simplify function setenv_foreign_option

2025-07-28 Thread flichtenheld (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1112?usp=email to look at the new patch set (#2). Change subject: options: Simplify function setenv_foreign_option ...

[Openvpn-devel] [XS] Change in openvpn[master]: unit_tests/plugins/auth-pam: fix stdint.h related build error on fedo...

2025-07-28 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1118?usp=email ) Change subject: unit_tests/plugins/auth-pam: fix stdint.h related build error on fedora 42 ..

[Openvpn-devel] [S] Change in openvpn[master]: management: resync timer on bytecount interval change

2025-07-28 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1113?usp=email ) Change subject: management: resync timer on bytecount interval change ..

[Openvpn-devel] [S] Change in openvpn[master]: management: resync timer on bytecount interval change

2025-07-25 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, ralf_lici. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1113?usp=email ) Change subject: management: resync timer on bytecount interval change

[Openvpn-devel] [M] Change in openvpn[master]: options: Clean up function setenv_foreign_option

2025-07-25 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1112?usp=email to review the following change. Change subject: options: Clean up function setenv_foreign_option ..

[Openvpn-devel] [M] Change in openvpn[master]: plugins: Clean up -Wconversion warnings

2025-07-25 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/?usp=email to review the following change. Change subject: plugins: Clean up -Wconversion warnings ...

[Openvpn-devel] [S] Change in openvpn[master]: ssl_common: Make sure ssl flags are treated as unsigned

2025-07-24 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1104?usp=email to review the following change. Change subject: ssl_common: Make sure ssl flags are treated as unsigned ...

[Openvpn-devel] [S] Change in openvpn[master]: crypto: Make sure crypto flags are treated as unsigned

2025-07-24 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1103?usp=email to review the following change. Change subject: crypto: Make sure crypto flags are treated as unsigned

[Openvpn-devel] [XS] Change in openvpn[master]: events: Make sure rwflags are treated as unsigned

2025-07-24 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1107?usp=email to review the following change. Change subject: events: Make sure rwflags are treated as unsigned .

[Openvpn-devel] [M] Change in openvpn[master]: manage: Make sure various management flags are treated as unsigned

2025-07-24 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1105?usp=email to review the following change. Change subject: manage: Make sure various management flags are treated as unsigned ...

[Openvpn-devel] [S] Change in openvpn[master]: comp: Make sure comp flags are treated as unsigned

2025-07-24 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1102?usp=email to review the following change. Change subject: comp: Make sure comp flags are treated as unsigned

[Openvpn-devel] [S] Change in openvpn[master]: forward: Make sure pip flags are treated as unsigned

2025-07-24 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1108?usp=email to review the following change. Change subject: forward: Make sure pip flags are treated as unsigned ..

[Openvpn-devel] [S] Change in openvpn[master]: route: Make sure various route flags are treated as unsigned

2025-07-24 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1109?usp=email to review the following change. Change subject: route: Make sure various route flags are treated as unsigned ..

[Openvpn-devel] [M] Change in openvpn[master]: options: Make sure option types are treated as unsigned

2025-07-24 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1106?usp=email to review the following change. Change subject: options: Make sure option types are treated as unsigned ...

[Openvpn-devel] [XS] Change in openvpn[master]: ssl_openssl: Fix type of sslopts argument to SSL_CTX_set_options

2025-07-23 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1101?usp=email to review the following change. Change subject: ssl_openssl: Fix type of sslopts argument to SSL_CTX_set_options ..

[Openvpn-devel] [M] Change in openvpn[master]: Check message id/acked ids too when doing sessionid cookie checks

2025-07-22 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1067?usp=email ) Change subject: Check message id/acked ids too when doing sessionid cookie checks ..

[Openvpn-devel] [S] Change in openvpn[master]: Fix socketpair return status not being checked in port share code

2025-07-22 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/770?usp=email ) Change subject: Fix socketpair return status not being checked in port share code ...

[Openvpn-devel] [S] Change in openvpn[release/2.6]: GHA: Update dependencies July 2025 (2.6)

2025-07-22 Thread flichtenheld (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, uddr, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1080?usp=email to look at the new patch set (#2). The change is no longer submittable: checks~ChecksSubmitRule is uns

[Openvpn-devel] [S] Change in openvpn[master]: GHA: Dependency updates July 2025

2025-07-22 Thread flichtenheld (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, uddr, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1079?usp=email to look at the new patch set (#5). The change is no longer submittable: checks~ChecksSubmitRule is uns

[Openvpn-devel] [S] Change in openvpn[master]: GHA: Dependency updates July 2025

2025-07-22 Thread flichtenheld (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, uddr, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1079?usp=email to look at the new patch set (#4). The change is no longer submittable: checks~ChecksSubmitRule is uns

[Openvpn-devel] [M] Change in openvpn[master]: multipeer: introduce asymmetric peer-id

2025-07-17 Thread flichtenheld (Code Review)
Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1089?usp=email ) Change subject: multipeer: introduce asymmetric peer-id .. P

[Openvpn-devel] [S] Change in openvpn[master]: Do not check for pkcs11-helper when pkcs11 is not enabled

2025-07-16 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1085?usp=email ) Change subject: Do not check for pkcs11-helper when pkcs11 is not enabled ...

[Openvpn-devel] [S] Change in openvpn[master]: configure.ac: Remove use of PKCS11_HELPER_LIBS in mbedTLS checks

2025-07-16 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1088?usp=email to review the following change. Change subject: configure.ac: Remove use of PKCS11_HELPER_LIBS in mbedTLS checks ..

[Openvpn-devel] [S] Change in openvpn[master]: README.dco: update Linux instructions

2025-07-16 Thread flichtenheld (Code Review)
Attention is currently required from: ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1087?usp=email ) Change subject: README.dco: update Linux instructions .. Patch S

[Openvpn-devel] [S] Change in openvpn[master]: README.dco: update Linux instructions

2025-07-16 Thread flichtenheld (Code Review)
Attention is currently required from: ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1087?usp=email ) Change subject: README.dco: update Linux instructions .. Patch S

[Openvpn-devel] [S] Change in openvpn[master]: README.dco: update Linux instructions

2025-07-16 Thread flichtenheld (Code Review)
Attention is currently required from: ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1087?usp=email ) Change subject: README.dco: update Linux instructions .. Patch S

[Openvpn-devel] [M] Change in openvpn[master]: Cleanup/simplify mbed TLS related define from autoconf

2025-07-15 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1081?usp=email ) Change subject: Cleanup/simplify mbed TLS related define from autoconf ...

[Openvpn-devel] [M] Change in openvpn[master]: Cleanup/simplify mbed TLS related define from autoconf

2025-07-15 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1081?usp=email ) Change subject: Cleanup/simplify mbed TLS related define from autoconf ...

[Openvpn-devel] [M] Change in openvpn[master]: Cleanup/simplify mbed TLS related define from autoconf

2025-07-15 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1081?usp=email ) Change subject: Cleanup/simplify mbed TLS related define from autoconf ..

[Openvpn-devel] [M] Change in openvpn[master]: Cleanup/simplify mbed TLS related define from autoconf

2025-07-14 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1081?usp=email ) Change subject: Cleanup/simplify mbed TLS related define from autoconf ..

[Openvpn-devel] [S] Change in openvpn[master]: Do not check for pkcs11-helper when pkcs11 is not enabled

2025-07-14 Thread flichtenheld (Code Review)
Attention is currently required from: flichtenheld. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1085?usp=email ) Change subject: Do not check for pkcs11-helper when pkcs11 is not enabled

[Openvpn-devel] [S] Change in openvpn[master]: Do not check for pkcs11-helper when pkcs11 is not enabled

2025-07-14 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1085?usp=email ) Change subject: Do not check for pkcs11-helper when pkcs11 is not enabled ...

[Openvpn-devel] [S] Change in openvpn[master]: mac dns: compare servers before restoring backup

2025-07-11 Thread flichtenheld (Code Review)
Attention is currently required from: d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1075?usp=email ) Change subject: mac dns: compare servers before restoring backup .

[Openvpn-devel] [M] Change in openvpn[master]: reliable: Review and fix gc_arena usage

2025-07-11 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1083?usp=email ) Change subject: reliable: Review and fix gc_arena usage .. Patch Set 3:

[Openvpn-devel] [S] Change in openvpn[master]: Do not compile mbed key helper with MBEDTLS_SSL_KEYING_MATERIAL_EXPORT

2025-07-10 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1081?usp=email ) Change subject: Do not compile mbed key helper with MBEDTLS_SSL_KEYING_MATERIAL_EXPORT .

[Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE message sender: enabling the server to send PUSH_UPDATE c...

2025-07-10 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, mrbff, plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/869?usp=email ) Change subject: PUSH_UPDATE message sender: enabling the server to send PUSH_UPDATE control messages ...

[Openvpn-devel] [M] Change in openvpn[master]: reliable: Move gc_arena inside reliable_print_ids

2025-07-10 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1083?usp=email to review the following change. Change subject: reliable: Move gc_arena inside reliable_print_ids .

[Openvpn-devel] [XS] Change in openvpn[master]: Fix compiler warning in reliable.c with --disable-debug

2025-07-10 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1082?usp=email to review the following change. Change subject: Fix compiler warning in reliable.c with --disable-debug ...

[Openvpn-devel] [M] Change in openvpn[master]: move macOS dns-updown common code into functions

2025-07-09 Thread flichtenheld (Code Review)
Attention is currently required from: d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1074?usp=email ) Change subject: move macOS dns-updown common code into functions .

[Openvpn-devel] [M] Change in openvpn[master]: move macOS dns-updown common code into functions

2025-07-09 Thread flichtenheld (Code Review)
Attention is currently required from: d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1074?usp=email ) Change subject: move macOS dns-updown common code into functions .

[Openvpn-devel] [S] Change in openvpn[master]: GHA: Dependency updates July 2025

2025-07-09 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1079?usp=email to look at the new patch set (#2). Change subject: GHA: Dependency updates July 2025

[Openvpn-devel] [XS] Change in openvpn[master]: Do not compile mbed key helper with MBEDTLS_SSL_KEYING_MATERIAL_EXPORT

2025-07-09 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1081?usp=email ) Change subject: Do not compile mbed key helper with MBEDTLS_SSL_KEYING_MATERIAL_EXPORT .

[Openvpn-devel] [S] Change in openvpn[master]: mac dns: compare servers before restoring backup

2025-07-09 Thread flichtenheld (Code Review)
Attention is currently required from: d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1075?usp=email ) Change subject: mac dns: compare servers before restoring backup .

[Openvpn-devel] [XS] Change in openvpn[master]: Do not compile mbed key helper with MBEDTLS_SSL_KEYING_MATERIAL_EXPORT

2025-07-09 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1081?usp=email ) Change subject: Do not compile mbed key helper with MBEDTLS_SSL_KEYING_MATERIAL_EXPORT .

[Openvpn-devel] [XS] Change in openvpn[master]: Do not compile mbed key helper with MBEDTLS_SSL_KEYING_MATERIAL_EXPORT

2025-07-09 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1081?usp=email ) Change subject: Do not compile mbed key helper with MBEDTLS_SSL_KEYING_MATERIAL_EXPORT .

[Openvpn-devel] [S] Change in openvpn[release/2.6]: GHA: Update dependencies July 2025 (2.6)

2025-07-09 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1080?usp=email to review the following change. Change subject: GHA: Update dependencies July 2025 (2.6) ..

[Openvpn-devel] [S] Change in openvpn[master]: GHA: Dependency updates July 2025

2025-07-09 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1079?usp=email to review the following change. Change subject: GHA: Dependency updates July 2025 .

[Openvpn-devel] [S] Change in openvpn[master]: mac dns: compare servers before restoring backup

2025-07-09 Thread flichtenheld (Code Review)
Attention is currently required from: d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1075?usp=email ) Change subject: mac dns: compare servers before restoring backup .

[Openvpn-devel] [S] Change in openvpn[master]: mac dns: compare servers before restoring backup

2025-07-07 Thread flichtenheld (Code Review)
Attention is currently required from: d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1075?usp=email ) Change subject: mac dns: compare servers before restoring backup .

[Openvpn-devel] [S] Change in openvpn[master]: Fix new doxygen warnings about using @return in void functions

2025-07-02 Thread flichtenheld (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos. Hello ordex, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1029?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code

[Openvpn-devel] [S] Change in openvpn[master]: Fix new doxygen warnings about using @return in void functions

2025-07-02 Thread flichtenheld (Code Review)
flichtenheld has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/1072?usp=email ) Change subject: Fix new doxygen warnings about using @return in void functions .. Abandoned duplicate -- To view, visit http://ge

[Openvpn-devel] [S] Change in openvpn[master]: Fix new doxygen warnings about using @return in void functions

2025-07-02 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1072?usp=email to review the following change. Change subject: Fix new doxygen warnings about using @return in void functions

[Openvpn-devel] [XS] Change in openvpn[master]: packet_id: Fix build with --disable-debug

2025-06-30 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1071?usp=email to review the following change. Change subject: packet_id: Fix build with --disable-debug .

[Openvpn-devel] [M] Change in openvpn[master]: Define a .clang-format file for the project

2025-06-27 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/790?usp=email ) Change subject: Define a .clang-format file for the project .. Pa

[Openvpn-devel] [L] Change in openvpn[master]: Remove uncrustify config and reformat-all.sh, switch GHA

2025-06-27 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/830?usp=email to look at the new patch set (#11). Change subject: Remove uncrustify config and reformat-all.

[Openvpn-devel] [S] Change in openvpn[master]: Update git-pre-commit-uncrustify.sh to handle clang-format

2025-06-27 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1070?usp=email to review the following change. Change subject: Update git-pre-commit-uncrustify.sh to handle clang-format

[Openvpn-devel] [M] Change in openvpn[master]: run forced --dns-updown without --script-security

2025-06-26 Thread flichtenheld (Code Review)
Attention is currently required from: d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1065?usp=email ) Change subject: run forced --dns-updown without --script-security

[Openvpn-devel] [M] Change in openvpn[master]: run forced --dns-updown without --script-security

2025-06-26 Thread flichtenheld (Code Review)
Attention is currently required from: d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1065?usp=email ) Change subject: run forced --dns-updown without --script-security

[Openvpn-devel] [XS] Change in openvpn[master]: t_server_null: Test different permutations of --dh

2025-06-03 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1038?usp=email ) Change subject: t_server_null: Test different permutations of --dh .. P

[Openvpn-devel] [XS] Change in openvpn[master]: t_server_null: Test different permutations of --dh

2025-06-02 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1038?usp=email to review the following change. Change subject: t_server_null: Test different permutations of --dh

[Openvpn-devel] [XS] Change in openvpn[master]: Do not segfault on missing --dh in server config

2025-06-02 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1037?usp=email to review the following change. Change subject: Do not segfault on missing --dh in server config ..

[Openvpn-devel] [XS] Change in openvpn[release/2.6]: git-pre-commit-uncrustify: Make sure to not run on branches with clan...

2025-06-02 Thread flichtenheld (Code Review)
flichtenheld has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/1031?usp=email ) Change subject: git-pre-commit-uncrustify: Make sure to not run on branches with clang-format .. Abandoned Not the wanted way fo

[Openvpn-devel] [M] Change in openvpn[master]: Delete old sample-windows file and obsolete Windows sample handling

2025-06-02 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1036?usp=email to look at the new patch set (#2). Change subject: Delete old sample-windows file and obsolete Windows sample handling .

[Openvpn-devel] [M] Change in openvpn[master]: Delete old sample-windows file

2025-06-02 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1036?usp=email to review the following change. Change subject: Delete old sample-windows file

[Openvpn-devel] [M] Change in openvpn[master]: Define a .clang-format file for the project

2025-06-02 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/790?usp=email ) Change subject: Define a .clang-format file for the project .. Pa

[Openvpn-devel] [M] Change in openvpn[master]: Remove contrib/pull-resolv-conf

2025-05-28 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1034?usp=email to review the following change. Change subject: Remove contrib/pull-resolv-conf ...

[Openvpn-devel] [M] Change in openvpn[master]: Changes.rst: Collect, fix, and improve entries for 2.7 release

2025-05-28 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos, selvanair, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1032?usp=email ) Change subject: Changes.rst: Collect, fix, and improve entries for 2.7 release .

[Openvpn-devel] [M] Change in openvpn[master]: Changes.rst: Collect, fix, and improve entries for 2.7 release

2025-05-28 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos, selvanair, stipa. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1032?usp=email to look at the new patch set (#5). Change subject: Changes.rst: Collect, fix, and improve entrie

[Openvpn-devel] [S] Change in openvpn[master]: Use mbedtls_ssl_export_keying_material()

2025-05-28 Thread flichtenheld (Code Review)
Attention is currently required from: MaxF, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1041?usp=email ) Change subject: Use mbedtls_ssl_export_keying_material() .. Patch

[Openvpn-devel] [S] Change in openvpn[master]: mbedtls: Allow TLS 1.3 if available

2025-05-28 Thread flichtenheld (Code Review)
Attention is currently required from: MaxF. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1042?usp=email ) Change subject: mbedtls: Allow TLS 1.3 if available .. Patch Set 3: Code-Rev

[Openvpn-devel] [M] Change in openvpn[master]: Changes.rst: Collect, fix, and improve entries for 2.7 release

2025-05-28 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos, selvanair, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1032?usp=email ) Change subject: Changes.rst: Collect, fix, and improve entries for 2.7 release .

[Openvpn-devel] [M] Change in openvpn[master]: Remove HAVE_EXPORT_KEYING_MATERIAL macro

2025-05-27 Thread flichtenheld (Code Review)
Attention is currently required from: MaxF, cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1043?usp=email ) Change subject: Remove HAVE_EXPORT_KEYING_MATERIAL macro ..

[Openvpn-devel] [M] Change in openvpn[master]: Changes.rst: Collect, fix, and improve entries for 2.7 release

2025-05-27 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1032?usp=email ) Change subject: Changes.rst: Collect, fix, and improve entries for 2.7 release

[Openvpn-devel] [M] Change in openvpn[master]: Changes.rst: Collect, fix, and improve entries for 2.7 release

2025-05-27 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1032?usp=email to look at the new patch set (#4). Change subject: Changes.rst: Collect, fix, and improve entries fo

[Openvpn-devel] [M] Change in openvpn[master]: Changes.rst: Collect, fix, and improve entries for 2.7 release

2025-05-27 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1032?usp=email ) Change subject: Changes.rst: Collect, fix, and improve entries for 2.7 release

[Openvpn-devel] [M] Change in openvpn[master]: Changes.rst: Collect, fix, and improve entries for 2.7 release

2025-05-27 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1032?usp=email to look at the new patch set (#3). Change subject: Changes.rst: Collect, fix, and improve entries fo

[Openvpn-devel] [M] Change in openvpn[master]: Changes.rst: Collect, fix, and improve entries for 2.7 release

2025-05-27 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1032?usp=email to look at the new patch set (#2). Change subject: Changes.rst: Collect, fix, and improve entries fo

[Openvpn-devel] [M] Change in openvpn[master]: Changes.rst: Collect, fix, and improve entries for 2.7 release

2025-05-27 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1032?usp=email ) Change subject: Changes.rst: Collect, fix, and improve entries for 2.7 release

[Openvpn-devel] [M] Change in openvpn[master]: Changes.rst: Collect, fix, and improve entries for 2.7 release

2025-05-26 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1032?usp=email to review the following change. Change subject: Changes.rst: Collect, fix, and improve entries for 2.7 release

[Openvpn-devel] [L] Change in openvpn[master]: Remove uncrustify config and scripts, switch GHA

2025-05-26 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/830?usp=email to look at the new patch set (#10). The following approvals got outdated and were removed: Code

[Openvpn-devel] [XS] Change in openvpn[release/2.6]: git-pre-commit-uncrustify: Make sure to not run on branches with clan...

2025-05-26 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1031?usp=email to review the following change. Change subject: git-pre-commit-uncrustify: Make sure to not run on branches with clang-for

[Openvpn-devel] [XL] Change in openvpn[master]: Reformat the whole project with clang-format

2025-05-26 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/791?usp=email ) Change subject: Reformat the whole project with clang-format ...

[Openvpn-devel] [S] Change in openvpn[master]: Fix various badly placed comments in preparation for reformat

2025-05-26 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1030?usp=email to review the following change. Change subject: Fix various badly placed comments in preparation for reformat .

[Openvpn-devel] [M] Change in openvpn[master]: Define a .clang-format file for the project

2025-05-26 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/790?usp=email to look at the new patch set (#15). Change subject: Define a .clang-format file for the project ..

[Openvpn-devel] [XL] Change in openvpn[master]: Reformat the whole project with clang-format

2025-05-26 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/791?usp=email ) Change subject: Reformat the whole project with clang-format ...

[Openvpn-devel] [M] Change in openvpn[master]: Remove HAVE_EXPORT_KEYING_MATERIAL macro

2025-05-23 Thread flichtenheld (Code Review)
Attention is currently required from: MaxF, cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1043?usp=email ) Change subject: Remove HAVE_EXPORT_KEYING_MATERIAL macro ..

[Openvpn-devel] [M] Change in openvpn[master]: Remove HAVE_EXPORT_KEYING_MATERIAL macro

2025-05-23 Thread flichtenheld (Code Review)
Attention is currently required from: MaxF, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1043?usp=email ) Change subject: Remove HAVE_EXPORT_KEYING_MATERIAL macro .. Patch

[Openvpn-devel] [S] Change in openvpn[master]: Fix new doxygen warnings about using @return in void functions

2025-05-20 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1029?usp=email to review the following change. Change subject: Fix new doxygen warnings about using @return in void functions

[Openvpn-devel] [M] Change in openvpn[master]: Doxygen: Fix missing parameter warnings

2025-05-19 Thread flichtenheld (Code Review)
Attention is currently required from: flichtenheld. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/848?usp=email to look at the new patch set (#6). The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied now. Ch

[Openvpn-devel] [S] Change in openvpn[master]: t_server_null: print error when server startup fails

2025-05-19 Thread flichtenheld (Code Review)
Attention is currently required from: mattock, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1024?usp=email ) Change subject: t_server_null: print error when server startup fails ...

[Openvpn-devel] [S] Change in openvpn[master]: GHA: Dependency and Actions update May 2025

2025-05-09 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1001?usp=email to review the following change. Change subject: GHA: Dependency and Actions update May 2025 ...

[Openvpn-devel] [M] Change in openvpn[master]: CMake: Reorganize header and symbol tests

2025-05-08 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/924?usp=email to look at the new patch set (#2). Change subject: CMake: Reorganize header and symbol tests .

  1   2   3   4   5   6   7   8   >