Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1107?usp=email
to review the following change.
Change subject: events: Make sure rwflags are treated as unsigned
......................................................................
events: Make sure rwflags are treated as unsigned
event_set_return.rwflags is already unsigned, make sure the
flags are as well to avoid spurious conversion warnings.
Change-Id: I0272b709b907545de05bfded03a649b259ce5af6
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M src/openvpn/event.h
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/07/1107/1
diff --git a/src/openvpn/event.h b/src/openvpn/event.h
index 389f80d..eddff4d 100644
--- a/src/openvpn/event.h
+++ b/src/openvpn/event.h
@@ -36,8 +36,8 @@
#define WRITE_SHIFT 1
#define EVENT_UNDEF 4
-#define EVENT_READ (1 << READ_SHIFT)
-#define EVENT_WRITE (1 << WRITE_SHIFT)
+#define EVENT_READ (1u << READ_SHIFT)
+#define EVENT_WRITE (1u << WRITE_SHIFT)
/* event flags returned by io_wait.
*
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1107?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0272b709b907545de05bfded03a649b259ce5af6
Gerrit-Change-Number: 1107
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
