Re: [Openvpn-devel] Heartbleed

2014-04-08 Thread Davide Brini
On Tue, 08 Apr 2014 11:08:59 +0200, Tore Anderson wrote: > I'm guessing that everyone has seen http://heartbleed.com/ by now. > > My question is simple: Could anyone confirm whether or not OpenVPN is > vulnerable (when linked to a vulnerable version of OpenSSL)? This is James' reply on the dev

[Openvpn-devel] [PATCHv2] Allow inlining of --auth-user-pass

2013-10-12 Thread Davide Brini
] is still supported and [up] is expected to contain username and password on two lines. Signed-off-by: Davide Brini --- src/openvpn/init.c|6 +-- src/openvpn/misc.c|2 +- src/openvpn/options.c | 54 +-- src/openvpn/options.h |2 + src/openvpn/ssl.c

Re: [Openvpn-devel] [PATCH] Allow inlining of --auth-user-pass

2013-10-12 Thread Davide Brini
So here we go, your points are all valid. The patch you attached has a spurious line, or maybe it's just my client that doesn't show it correctly, I see @@ -5835,7 +5872,12 @@ VERIFY_PERMISSION (OPT_P_GENERAL); if (p[1]) { - options->auth_user_pass_file = p[1]; +

Re: [Openvpn-devel] [PATCH] Allow inlining of --auth-user-pass

2013-10-06 Thread Davide Brini
ication (only tested inline settzing, not with a file).   Joerg Original-Nachricht Gesendet: Samstag, 05. Oktober 2013 um 15:57 Uhr Von: "Max Muster" An: "Davide Brini" Cc: openvpn-devel@lists.sourceforge.net Betreff: Re: [Openvpn-devel] [PATCH]

Re: [Openvpn-devel] [PATCH] Allow inlining of --auth-user-pass

2013-10-03 Thread Davide Brini
syntax auth-user-pass [up] is still supported and [up] is expected to contain username and password on two lines. Signed-off-by: Davide Brini --- src/openvpn/init.c|6 +-- src/openvpn/misc.c|2 +- src/openvpn/options.c | 56 src/openvpn/options.h |2

[Openvpn-devel] [PATCH] Allow inlining of --auth-user-pass

2013-10-02 Thread Davide Brini
username and password on two lines. Signed-off-by: Davide Brini --- src/openvpn/init.c|9 +++-- src/openvpn/misc.c|2 +- src/openvpn/options.c | 56 src/openvpn/options.h |2 + src/openvpn/ssl.c | 98

[Openvpn-devel] [PATCH] Document authfile for socks server

2013-09-15 Thread Davide Brini
It looks like it's possible to specify an optional authfile as third argument of the "socks-proxy" directive. This patch updates the man page to document that. Signed-off-by: Davide Brini --- doc/openvpn.8 |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [Openvpn-devel] understanding of tun and vpn

2013-06-04 Thread Davide Brini
On Tue, 4 Jun 2013 12:15:30 +0200, wen lui wrote: > let me explain my understanding on tun/tap >[snip] Sorry, but what does all this have to do with OpenVPN development? -- D.

[Openvpn-devel] Provide more accurate warning message

2013-05-30 Thread Davide Brini
Very simple fix. --- src/openvpn/init.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/init.c b/src/openvpn/init.c index 2a0ba85..9a9c49a 100644 --- a/src/openvpn/init.c +++ b/src/openvpn/init.c @@ -2547,7 +2547,7 @@ do_option_warnings (struct context *c) el

Re: [Openvpn-devel] Correct Man Page: client-to-client

2013-01-08 Thread Davide Brini
On Tue, 8 Jan 2013 07:41:59 -0600, Eric Crist wrote: > I'm certain this is the behavior for TAP, but I'll do some due-dilligence > and generate a few different scenarios and verify. It's entirely > possible this behavior is only present with the TAP adapter. I'll post > my findings later this w

Re: [Openvpn-devel] Correct Man Page: client-to-client

2013-01-07 Thread Davide Brini
On Mon, 7 Jan 2013 14:30:01 -0600, Eric Crist wrote: > This is something I've been meaning to address for quite some time, since > the documentation is very, very wrong. I'm not very good at reading the > code (yet), so please correct me if I'm wrong. This update is based on > behavior I've see

Re: [Openvpn-devel] [PATCH] fix sending udp datagrams from wrong ip address

2012-09-24 Thread Davide Brini
On Mon, 24 Sep 2012 19:20:18 +0200, Krzysztof Witek wrote: > From: Krzysztof Witek > > If multiple ip addresses of the same subnet are configured on an > interface, openvpn may not send udp datagrams to the peer > using the correct source ip address. > > If a host sends the udp datagrams to th

Re: [Openvpn-devel] Authentication Plugin Sending Reason For Auth Deny

2012-08-31 Thread Davide Brini
On Fri, 31 Aug 2012 06:39:31 -0600, joshua gross wrote: > Hi, > I working on an authentication plugin for openvpn (remote authentication). > I would like to be able to send a reason to the client for denying > authentication. Is this possible through a plugin? or the management > console? I've

Re: [Openvpn-devel] [PATCH] When using multihome, create environment variables for target IP and interface on the server

2011-10-24 Thread Davide Brini
On Mon, 24 Oct 2011 12:07:49 +0200, David Sommerseth wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 19/09/11 19:19, Davide Brini wrote: > > Signed-off-by: Davide Brini > > > > This patch creates two new environment variables: "multihome_i

[Openvpn-devel] [PATCH] When using multihome, create environment variables for target IP and interface on the server

2011-09-19 Thread Davide Brini
Signed-off-by: Davide Brini This patch creates two new environment variables: "multihome_iface" and "multihome_ip", which contain respectively the interface name and IP address where the client connection came in, so scripts can use them. Tested on IPv4, "works for me&q

[Openvpn-devel] Incorrect instructions in tester documentation

2011-09-19 Thread Davide Brini
On the "TesterDocumentation" page, the instructions say When testing this version of OpenVPN, we would appreciate if all deprecated features would be disabled by default. We want to know how OpenVPN behaves for you without these features. When doing the compile-time configuration of OpenVPN, pleas

Re: [Openvpn-devel] [PATCH] Bind only to specified interface

2011-03-12 Thread Davide Brini
On Sat, 12 Mar 2011 00:35:17 -0300 Federico Heinz wrote: > The reason I looked into this in the first place was that, unlike > those TCP-based protocols, I couldn't get OpenVPN to work on a > firewall with two external IP addresses without running two deamons, > each one bound to one interface on

Re: [Openvpn-devel] [Openvpn-users] udp6 source-address wrong with more than one ipv6-address on server

2011-01-28 Thread Davide Brini
On Friday 28 Jan 2011 11:57:30 Stefan Hellermann wrote: > > Are you using the "multihome" option in the server configuration? As far > > as I can tell, using "multihome" uses the PKTINFO information to source > > UDP replies from the correct IP address; however, while it does work for > > IPv4, I

Re: [Openvpn-devel] [Openvpn-users] udp6 source-address wrong with more than one ipv6-address on server

2011-01-28 Thread Davide Brini
On Friday 28 Jan 2011 00:07:37 Stefan Hellermann wrote: > I have a problem with proto udp6 (tun inside). My Openvpn-server should > be reachable on multiple IPv6-addresses over UDP6. The packets arrive at > the correct IP, but Openvpn answers them on a default ip, not on the one > where the packe

Re: [Openvpn-devel] [OpenVPN 2.1.4 BUG]: hard-coded values in Makefiles for down-root and auth-pam plugins prevent cross compilation

2010-12-30 Thread Davide Brini
On Thu, 30 Dec 2010 21:02:25 + Mr Dash Four wrote: > On a side note, could you let me know how to submit a bug with the Trac > system - I spent a good couple of hours and still didn't manage to find > a way to submit a bug? You have to register. Start here: https://community.openvpn.net/p

Re: [Openvpn-devel] Documentation and alternative SSL backend patches

2010-12-02 Thread Davide Brini
On Thu, 02 Dec 2010 12:10:29 +0100 Matthias Andree wrote: > > most distro switch from openssl to nss. is there any reason you switch > > to polarssl in stead of nss? > > > > What do you base the "most distro" assessment on? > > Are you aware of any website discussing the advantages of the "big

Re: [Openvpn-devel] Intelligent OpenVPN service?

2010-10-18 Thread Davide Brini
On Mon, 18 Oct 2010 13:19:53 -0500 "Daniel Johnson" wrote: > I want to set up company laptops and remote desktops to use OpenVPN > as a service, but it should *only* connect if the computer does not > already have a connection (such as locally wired or internal > wireless). Sorry for the silly q

Re: [Openvpn-devel] features

2010-07-24 Thread Davide Brini
On Sat, 24 Jul 2010 12:30:09 -0700 Alex T wrote: > I have 2 suggestions regarding openvpn (client mode): > - the use of SHA512 with the TLS ciphers OpenVPN does not implement any encryption; it relies on OpenSSL. So, if the OpenSSL library used by OpenVPN supports it, so does OpenVPN. > - some

Re: [Openvpn-devel] FW: Patch submission - git crash course ?

2010-06-16 Thread Davide Brini
On Wednesday 16 Jun 2010 13:03:39 David Balažic wrote: > Hi! > > Is there some crash course for using git with openvpn sources? > > I know svn and other tools, but not git. > > So i need steps list like: > > apt-get install git > svn co http://repo.openvpn.net/patchme # translated into git synt

Re: [Openvpn-devel] PATCH: remove bashisms from easy-rsa

2010-06-06 Thread Davide Brini
On Sunday 06 June 2010, Toby Thain wrote: > >> Most of the common GNU utilities (including gcc) are in the standard > >> Solaris install, either via /usr/sfw/ or by using g prefix (e.g. > >> gawk, > >> gmake). > > > > Possibly, but it still means that either scripts using standard > > names and ex

Re: [Openvpn-devel] PATCH: remove bashisms from easy-rsa

2010-06-05 Thread Davide Brini
On Saturday 05 June 2010, Toby Thain wrote: > > > > I'm not sure why Solaris has been insisting for ages now in shipping > > default tools that are either old, with less features or downright broken. > > It's not just about sh; other popular tools like awk are also pretty much > > unusable by def

Re: [Openvpn-devel] PATCH: remove bashisms from easy-rsa

2010-06-05 Thread Davide Brini
On Saturday 05 June 2010, David Sommerseth wrote: > Yes, that can be seen as a solution for some people. But then it would > be better for us to explicitly require the needed shell rather to tell > them to (w)hack their system "because easy-rsa don't support old Solaris > /bin/sh". > > We should

Re: [Openvpn-devel] PATCH: remove bashisms from easy-rsa

2010-06-05 Thread Davide Brini
On Saturday 05 June 2010, David Sommerseth wrote: > On 05/06/10 00:49, Matthias Andree wrote: > > Note that some parts of the scripts may be Solaris /bin/sh unfriendly, > > for instance, Solaris's sh doesn't support test -e or [ -e. My patch > > does not address this. > > This makes me very reluc

[Openvpn-devel] [PATCH] Exclude ping and control packets from activity

2010-05-02 Thread Davide Brini
e packet is not a ping or TLS control packet. openvpn.8: Updated the description of --inactive to describe the new semantics. ping.c: Set c->c2.buf.len = 0 after the ping packet has been generated and encrypted. Signed-off-by: Davide Brini --- forward.c |5 +++-- openvpn.8

Re: [Openvpn-devel] [TESTING NEEDED] Using --inactive and --ping seems to defeat each other

2010-05-01 Thread Davide Brini
On Friday 30 April 2010, Davide Brini wrote: > Well, the obvious (and probably wrong, probably inefficient) way could > be to just check if the packet at hand is a ping message, and if it is > do not record it as "activity", eg > > if (! is_ping_msg (&c->c2.buf))

Re: [Openvpn-devel] [Openvpn-users] [TESTING NEEDED] Using --inactive and --ping seems to defeat each other

2010-04-30 Thread Davide Brini
On Friday 30 April 2010, Gert Doering wrote: > On Fri, Apr 30, 2010 at 06:24:20PM +0100, Davide Brini wrote: > > Well, the obvious (and probably wrong, probably inefficient) way could be > > to just check if the packet at hand is a ping message, and if it is do > > not record

Re: [Openvpn-devel] [Openvpn-users] [TESTING NEEDED] Using --inactive and --ping seems to defeat each other

2010-04-30 Thread Davide Brini
On Friday 30 April 2010, Davide Brini wrote: > if (! is_ping_msg (&c->c2.buf)) >register_activity (c, size); > > This is in two places: in process_outgoing_tun() and > process_outgoing_link(). Actually that would probably need to be done only in process_outgoing_lin

Re: [Openvpn-devel] [Openvpn-users] [TESTING NEEDED] Using --inactive and --ping seems to defeat each other

2010-04-30 Thread Davide Brini
On Friday 30 April 2010, David Sommerseth wrote: > >> I agree that that would be a wise change. However, I wonder: why change > >> the amount of bytes, if you can also simply not count the ping packets? > >> To me, it would seem a much more accurate way of determining whether the > >> connection i

Re: [Openvpn-devel] [PATCH] OCSP_check.sh: new check logic

2010-04-28 Thread Davide Brini
On Wednesday 28 April 2010, David Sommerseth wrote: > > +status=$(openssl ocsp -issuer "$issuer" \ > > +"$nonce" \ > > +-CAfile "$verify" \ > > +-url "$ocsp_url" \ > > +-serial "0x${serial}" 2>/dev/null) > > + > >

[Openvpn-devel] [PATCH] OCSP_check.sh: new check logic

2010-04-28 Thread Davide Brini
and explicitly looks for a "0x: good" line, and exit if either the command has a non-zero exit status, or the above line is not found. Doing that portably without bashisms requires some juggling around, so perhaps the code is slightly less clean now, but it does have many co

[Openvpn-devel] [PATCH] Serial number export, better

2010-04-27 Thread Davide Brini
nvpn.devel/3588 for more details. Signed-off-by: Davide Brini --- contrib/OCSP_check/OCSP_check.sh | 89 ++ openvpn.8|7 +++- ssl.c| 27 ++- 3 files changed, 119 insertions(+), 4 deletions(

Re: [Openvpn-devel] [PATCH] Serial number export, fixed

2010-04-26 Thread Davide Brini
On Monday 26 Apr 2010 16:19:20 David Sommerseth wrote: > > (I still think it would be nice to have some sort of channel to send > > errors to OpenVPN's main log from the children scripts or programs, so > > users could inspect it.) > > This begins to look very good! > > Just for the errors ... t

Re: [Openvpn-devel] [PATCH] Serial number export, fixed

2010-04-26 Thread Davide Brini
On Monday 26 Apr 2010 15:50:56 Karl O. Pinc wrote: > > > itself. So if the script could fail gracefully giving a hint like > > > "you've not done as I told you to", some support issues will be > > > avoided. > > > > Ok, that makes sense. I didn't look at it this way, but then I > > perfectly know

Re: [Openvpn-devel] [PATCH] Serial number export, fixed

2010-04-26 Thread Davide Brini
On Monday 26 Apr 2010 11:04:16 David Sommerseth wrote: > >> ... and have a check that this variable is set? If unset, exit with > >> error. > > > > Ah well, as I said the script is meant to be a barebone skeleton to > > demonstrate basic usage. That is by no means the only thing that lacks > > pr

Re: [Openvpn-devel] [PATCH] Serial number export, fixed

2010-04-26 Thread Davide Brini
On Monday 26 Apr 2010 00:13:39 David Sommerseth wrote: > Btw! Very good idea by introducing the OCSP_check.sh example! And even > a proper git patch! I like that :) Thanks! > > +# OCSP responder URL (mandatory) > > +ocsp_url="http://some.ocsp.server/"; > > +#ocsp_url="https://some.secure.ocsp

[Openvpn-devel] [PATCH] Serial number export, fixed

2010-04-25 Thread Davide Brini
"openssl ocsp". Signed-off-by: Davide Brini --- contrib/OCSP_check.sh | 67 + openvpn.8 |7 - ssl.c | 26 +-- 3 files changed, 96 insertions(+), 4 deletions(-) create m

Re: [Openvpn-devel] [PATCH] Revamped the script-security warning logging

2010-04-24 Thread Davide Brini
On Saturday 24 April 2010, David Sommerseth wrote: > From: David Sommerseth > > This is a first-cut of removing misleading warnings from the logs. > > The main task of this patch is to avoid reporting the > SCRIPT_SECURITY_WARNING over and over again, in addition to not show this > warning whe

Re: [Openvpn-devel] [PATCH-fixed] revocation

2010-04-23 Thread Davide Brini
On Friday 23 Apr 2010 11:13:21 David Sommerseth wrote: > On 22/04/10 23:37, Davide Brini wrote: > > --- openvpn-2.1.1/ssl.c 2010-02-28 22:17:45.0 + > > +++ openvpn-2.1.1-a/ssl.c 2010-04-22 22:33:40.0 +0100 > > @@ -788,9 +788,28 @@ verify_callback (in

Re: [Openvpn-devel] [PATCH] revocation

2010-04-23 Thread Davide Brini
On Friday 23 Apr 2010 00:34:38 Peter Stuge wrote: > Davide Brini wrote: > > the serial number is just an (almost) arbitrarily large number. Why > > would a CA choose such a serial number? > > In order to avoid a chosen-prefix collision that works among other > things

Re: [Openvpn-devel] [PATCH-fixed] revocation

2010-04-22 Thread Davide Brini
On Thursday 22 April 2010, Jan Just Keijser wrote: > > The only doubt I have is about error handling; in this case, if the > > allocation of the BIO fails, an error message is logged and nothing is > > done. Is this the right thing to do? > > I don't know if a FATAL error is such a good thing - n

Re: [Openvpn-devel] [PATCH-fixed] revocation

2010-04-22 Thread Davide Brini
On Thursday 22 April 2010, Davide Brini wrote: > (moving to -devel as this is obviously pertains there more than -users) Sorry, too quick! I posted an incomplete version of the patch. The attached one should be better. The only doubt I have is about error handling; in this case, if

[Openvpn-devel] [PATCH] revocation

2010-04-22 Thread Davide Brini
(moving to -devel as this is obviously pertains there more than -users) On Thursday 22 April 2010, Davide Brini wrote: > > > RFC 5280 says that "certificate users MUST be able to handle > > > serialNumber values up to 20 octets", so a 16-byte value looks valid to &g

Re: [Openvpn-devel] [PATCH] bash->bourne script cleanup

2010-04-22 Thread Davide Brini
On Thursday 22 Apr 2010 09:02:23 David Sommerseth wrote: > For future patches, would you mind adding a little bit more descriptive > text which can be used as commit log messages. I do write those commit > logs when I find it is needed, but adding a little bit more descriptions > of what the patc

Re: [Openvpn-devel] Slight modification to the contrib client.up script: DNS in server order

2010-04-21 Thread Davide Brini
On Wednesday 21 Apr 2010 14:49:13 Richard Monk wrote: > I had an issue come up where the clients were getting DNS entries in the > reverse order the server sends them when using the client.up contrib > script. Since the DNS servers on our system are in order from > closest->farthest network wise

Re: [Openvpn-devel] [PATCH] bash->bourne script cleanup

2010-04-19 Thread Davide Brini
On Monday 19 April 2010, David Sommerseth wrote: > I've done a quick test on one of my connections on Fedora 12 without any > resolvconf package (meaning it invokes the simple cp approach), and it > worked like a charm. > > Applied to bugfix2.1 and merged into allmerged. > Commit a9c9a89e96dc1e4e

Re: [Openvpn-devel] [PATCH] Mention mssfix default value in the man page

2010-04-19 Thread Davide Brini
On Sunday 18 Apr 2010 23:27:31 David Sommerseth wrote: > Added as commit 38025abb47f74363c3ee87ca7265e99a4055459e to bugfix2.1 > and merged into allmerged. Thanks. Though I understand it's not critical, in case you didn't notice, there's also another pending patch I submitted more than one month

Re: [Openvpn-devel] [PATCH] Harden create_temp_filename()

2010-04-16 Thread Davide Brini
On Friday 16 Apr 2010 10:35:54 Gert Doering wrote: > On Fri, Apr 16, 2010 at 11:16:32AM +0200, David Sommerseth wrote: > > I'll look more into this, as the only advantage is that if open() with > > O_EXCL|O_CREAT fails if the file exists, it should be used instead. > > Unfortunately, this won't h

[Openvpn-devel] [PATCH] Mention mssfix default value in the man page

2010-04-15 Thread Davide Brini
The man page does not mention that the default value of "mssfix" is 1450. --- openvpn-2.1.1/openvpn.8 2010-02-28 22:17:45.0 + +++ openvpn-2.1.1-a/openvpn.8 2010-04-15 19:43:53.0 +0100 @@ -1223,7 +1223,8 @@ their send packet sizes such that after the resulting UDP packet

Re: [Openvpn-devel] Bytecount Reporting

2010-03-17 Thread Davide Brini
On Wednesday 17 March 2010, open...@rkmorris.us wrote: > Hi Davide, > > > > Yes, that makes sense - and I was going to do that originally, but I > figured the real-time bytecount would result in less traffic (and text > parsing). One question though ... you say "status file". Do you really >

Re: [Openvpn-devel] Bytecount Reporting

2010-03-17 Thread Davide Brini
On Wednesday 17 March 2010, open...@rkmorris.us wrote: > I am trying to write an application that monitors traffic over an OpenVPN > link - by using bytecount information from the management interface. > However, after I telnet in, and enter "bytecount 1" (for 1 second > updates), I find that t

Re: [Openvpn-devel] [PATCH] bash->bourne script cleanup

2010-03-11 Thread Davide Brini
On Wednesday 10 March 2010, David Sommerseth wrote: > > Well, I was actually going to write a patch, but shortly after starting I > > found out that it would end up being essentially the same as Gentoo's > > scripts. Would it be worth separately maintaining something that has > > already been writ

Re: [Openvpn-devel] [PATCH] bash->bourne script cleanup

2010-03-10 Thread Davide Brini
On Wednesday 10 Mar 2010 15:45:32 David Sommerseth wrote: > On 01/03/10 00:26, Davide Brini wrote: > > On Sunday 28 February 2010, David Sommerseth wrote: > >> From: Dan Nelson > >> > >> Many of the scripts in the openvpn source have their shell set to &

Re: [Openvpn-devel] [PATCH] bash->bourne script cleanup

2010-02-28 Thread Davide Brini
On Sunday 28 February 2010, David Sommerseth wrote: > From: Dan Nelson > > Many of the scripts in the openvpn source have their shell set to > /bin/bash, but only two use bash features. The attached patch (against > openvpn-2.1_rc9) sets the shell on the rest of the scripts to /bin/sh for > bette

Re: [Openvpn-devel] 2.1 rc20 and multiple interfaces problem

2009-12-12 Thread Davide Brini
On Saturday 12 December 2009, James Yonan wrote: > Using nobind on the client for UDP client connections generates a socket > with a dynamic source port number. This is key because it means that > when the client reconnects, it does so with a new source port number, > and this allows OpenVPN to d

Re: [Openvpn-devel] 2.1 rc20 and multiple interfaces problem

2009-12-12 Thread Davide Brini
On Friday 11 December 2009, James Yonan wrote: > Try adding the "nobind" directive to your client config file. I think > this will solve the problem. That seems indeed to do it. Thank you very much! However, never in my life could I have imagined that this was due to a setting *on the client*.

Re: [Openvpn-devel] 2.1 rc20 and multiple interfaces problem

2009-11-12 Thread Davide Brini
On Thursday 12 November 2009, David Sommerseth wrote: > On 12/11/09 19:33, Olaf Fraczyk wrote: > > Hello, > > > > No, I wasn't using --multihome - I didn't know that this option exists > > and that is necessary. I haven't found it in man page and in > > documentation on the web page. The only plac