On Saturday 05 June 2010, David Sommerseth wrote: > On 05/06/10 00:49, Matthias Andree wrote:
> > Note that some parts of the scripts may be Solaris /bin/sh unfriendly, > > for instance, Solaris's sh doesn't support test -e or [ -e. My patch > > does not address this. > > This makes me very reluctant from accepting the patch, to be very > honest. I'd rather keep the current bashism which works on all > platforms where bash is available than to apply a patch which will break > the script from working on one of the supported platforms. > > I would rather like to see a patch which works safely on all platforms. > If 'test -e' or '[ -e' does not work in /bin/sh on some platforms, that > do indeed speak for keeping the bash support - unless there are other > ways how to solve this issue. I think Solaris should have a POSIX-compatible shell (korn shell, hence supporting test -e) under /usr/xpg4/bin/sh, although for some reason the default /bin/sh is an old bourne shell. People could link /bin/sh to the POSIX shell, and then the scripts should work fine. However, I think it would be sensible, before merging, to actually do that and test the scripts on a real Solaris system to check that they work as expected (unfortunately I don't have access to a Solaris system, otherwise I would do that myself). -- D.
