Tested this with various combinations of --port, --bind, --lport,
--local , etc. - a fascinating world of interesting effects.
I've fixed a small oversight in the commit message - the line needs to
read
Summary: socket bind is now only done if one of these is set
- --lport with not "0"
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/916?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: Make 'lport 0' no longer
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/916?usp=email )
Change subject: Make 'lport 0' no longer sufficient to do '--bind'.
..
Make 'lport 0' no longer sufficient to do '--bind'.
'lport ' used t
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/909?usp=email )
Change subject: Mention address if not unspecific on DNS failure
..
'lport ' used to trigger 'do socket bind', which is not
useful in itself for the 'lport 0' case (port 0 -> OS assigns a
random port, as it is done for unbound sockets) unless also binding
to a particular local IP address ('--local 192.0.2.1').
The trigger for 'lport has been used, do socket bind'
Attention is currently required from: cron2, flichtenheld.
ordex has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/916?usp=email )
Change subject: Make 'lport 0' no longer sufficient to do '--bind'.
..
Attention is currently required from: cron2, flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/916?usp=email )
Change subject: Make 'lport 0' no longer sufficient to do '--bind'.
...
On 18/03/2025 11:37, Marc Leeman wrote:
> trivial spelling error raised by lintian.
Thank you for the fix! And sorry for the slow response. It got handled
last week, but forgot to reply and do the final push to the public repos.
--
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/916?usp=email
to review the following change.
Change subject: Make 'lport 0' no longer sufficient to do '--bin
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/913?usp=email
to look at the new patch set (#3).
Change subject: Use USER_PASS_LEN instead of TLS_USERNAME_LEN for
override-user
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/915?usp=email )
Change subject: Directly use _countof in array initialisation
..
Patch S
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/915?usp=email )
Change subject: Directly use _countof in array initialisation
..
Directly use _countof in array initialisation
This fixes the build failur
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/913?usp=email )
Change subject: Use USER_PASS_LEN instead of TLS_USERNAME_LEN for
override-username
..
Patch Set 3: -Code-Review
--
To
cron2 has uploaded a new patch set (#2) to the change originally created by
plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/914?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld
Change subject: Improve documentation for override-username
...
Documentation-only, nothing to test. (Stared at the change nonetheless,
as we had discussions on some of the behavioural details - change makes
sense)
Your patch has been applied to the master branch.
commit 5c1c57684b6a1e6bce24605d55fe8dc3d9d3480e
Author: Arne Schwabe
Date: Mon Mar 24 14:54:3
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/913?usp=email )
Change subject: Use USER_PASS_LEN instead of TLS_USERNAME_LEN for
override-username
.
From: Arne Schwabe
- Mention that pushing auth-token-user only happens when OpenVPN also
generates the auth-token.
- mention that OpenVPN will only accept the original and overridden username
from a client
- suggest to use auth-token-user when a user generates the auth-token
Change-Id: Ifc74
cron2 has uploaded a new patch set (#3) to the change originally created by
plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/915?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld
Change subject: Directly use _countof in array initialisation
.
Thanks. Back to old-style const expressions, then...
Your patch has been applied to the master branch.
commit 1fc44d3b2ad3b96405650754a6e43f1576cda132
Author: Arne Schwabe
Date: Mon Mar 24 14:37:53 2025 +0100
Directly use _countof in array initialisation
Signed-off-by: Arne Schwabe
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/914?usp=email
to review the following change.
Change subject: Improve documentation for override-username
..
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/913?usp=email )
Change subject: Use USER_PASS_LEN instead of TLS_USERNAME_LEN for
override-username
.
From: Arne Schwabe
This fixes the build failures on MSVC cl compiler.
MSVC cl does not thinks of the expression of a const variable times
an integer to be compile time static. C23 introduce the constexpr
(like in C++) statement for that but we are only on C11 for now.
So directly use the _count
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/914?usp=email )
Change subject: Improve documentation for override-username
..
Patch Set
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/915?usp=email
to look at the new patch set (#2).
Change subject: Directly use _countof in array initialisation
..
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/915?usp=email
to review the following change.
Change subject: Directly use _countof in array initialisation
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/913?usp=email
to look at the new patch set (#2).
Change subject: Use USER_PASS_LEN instead of TLS_USERNAME_LEN for
override-user
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/913?usp=email
to review the following change.
Change subject: Use USER_PASS_LEN instead of TLS_USERNAME_LEN for
override-username
.
cron2 has uploaded a new patch set (#7) to the change originally created by
d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/908?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld
Change subject: win: calculate address string buffer size
.
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/908?usp=email )
Change subject: win: calculate address string buffer size
..
win: calculate address string buffer size
Instead of making the string buffer
Thanks for future-proofing this part of the code - it's fine today, but
we might bump the number of allowed DNS addresses to "8" one day, and
then the old code was at-risk for overflows...
I haven't actually tested it, just stared at it for a bit, asked mingw
("no warnings") and we have Frank's +2
From: Heiko Hund
Instead of making the string buffer statically sized for a max. of
four addresses, calculate it to hold up to the max number of addresses
a dns_cfg_message_t can hold (currently four as well). Improves the code
so that it doesn't rely on the addresses never being more than four i
cron2 has uploaded a new patch set (#2) to the change originally created by
plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/912?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by ordex
Change subject: Fix incorrect condition for checking password related chec
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/912?usp=email )
Change subject: Fix incorrect condition for checking password related check
..
Fix incorrect condition for checking password related check
Yeah, sorry for not noticing when reviewing db48cea. In retrospective
this is quite obviously the correct fix.
Added Github: reference, and URLs to sf.net mail archive & gerrit - the
archive at mail-archive.org is broken again :-(
Your patch has been applied to the master branch.
commit 15e663c
34 matches
Mail list logo
