Thanks for future-proofing this part of the code - it's fine today, but we might bump the number of allowed DNS addresses to "8" one day, and then the old code was at-risk for overflows...
I haven't actually tested it, just stared at it for a bit, asked mingw ("no warnings") and we have Frank's +2 in gerrit. Your patch has been applied to the master branch. commit 8ea5debaea01da5fee56fbad56b50820c1beee92 Author: Heiko Hund Date: Mon Mar 24 09:33:44 2025 +0100 win: calculate address string buffer size Signed-off-by: Heiko Hund <he...@ist.eigentlich.net> Acked-by: Frank Lichtenheld <fr...@lichtenheld.com> Message-Id: <20250324083350.4019-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31196.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel