Re: [Openvpn-devel] [PATCH applied] Re: console_systemd: remove the timeout when using 'systemd-ask-password'

On Tue, Jan 14, 2025 at 18:17:30 +0100, Gert Doering wrote: > I have taken this from the mailing list, as it has a thread hanging off > it with an ACK in it - which is easier than making the gerrit submission > a mail again, so it has a message-id to link to. Thanks! > Not much to test here - it'

[Openvpn-devel] [M] Change in openvpn[master]: ssl_openssl: Clean up unused functions and add missing "static"

cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/860?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: ssl_openssl: Clean up unused functions and add missing

[Openvpn-devel] [M] Change in openvpn[master]: ssl_openssl: Clean up unused functions and add missing "static"

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/860?usp=email ) Change subject: ssl_openssl: Clean up unused functions and add missing "static" .. ssl_openssl: Clean up unused functions and add missing "

[Openvpn-devel] [XS] Change in openvpn[master]: console_systemd: remove the timeout when using 'systemd-ask-password'

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/866?usp=email ) Change subject: console_systemd: remove the timeout when using 'systemd-ask-password' .. console_systemd: remove the timeout when using 's

[Openvpn-devel] [PATCH applied] Re: ssl_openssl: Clean up unused functions and add missing static

Indeed, unused functions, and not called from anywhere - so ACK (in gerrit). Your patch has been applied to the master branch. commit 758d28122954a30102f44b49e43f4b950553448a Author: Frank Lichtenheld Date: Tue Jan 14 17:49:38 2025 +0100 ssl_openssl: Clean up unused functions and add miss

[Openvpn-devel] [XS] Change in openvpn[master]: console_systemd: remove the timeout when using 'systemd-ask-password'

cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/866?usp=email ) Change subject: console_systemd: remove the timeout when using 'systemd-ask-password' ...

[Openvpn-devel] [PATCH applied] Re: console_systemd: remove the timeout when using 'systemd-ask-password'

I have taken this from the mailing list, as it has a thread hanging off it with an ACK in it - which is easier than making the gerrit submission a mail again, so it has a message-id to link to. Not much to test here - it's a trivial addition of an argv argument, and if David says "this is good" th

Re: [Openvpn-devel] [PATCH 1/1] console_systemd: remove the timeout when using `systemd-ask-password`

Hi, On Tue, Jan 14, 2025 at 02:47:58PM +0100, Frank Lichtenheld wrote: > Doing this as part of an experiment to add mail-submitted patches > to Gerrit. I *was* wondering since we had an ACK on the list already :-) gert -- "If was one thing all people took for granted, was conviction that if you

[Openvpn-devel] [M] Change in openvpn[master]: ssl_openssl: Clean up unused functions and add missing "static"

Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/860?usp=email ) Change subject: ssl_openssl: Clean up unused functions and add missing "static" ...

[Openvpn-devel] [M] Change in openvpn[master]: Remove various unused function parameters

Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/862?usp=email ) Change subject: Remove various unused function parameters .. Patc

[Openvpn-devel] [PATCH v2] Fix some trivial sign-compare compiler warnings

From: Frank Lichtenheld Change-Id: I1918c43202b87f0c987bfd9155c739da7dd02632 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn

[Openvpn-devel] [S] Change in openvpn[master]: Fix some trivial sign-compare compiler warnings

Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/865?usp=email ) Change subject: Fix some trivial sign-compare compiler warnings ..

[Openvpn-devel] [PATCH v1] ssl_openssl: Clean up unused functions and add missing "static"

From: Frank Lichtenheld Just some misc cleanups found while looking at the code. Change-Id: Ifa06a3cb843dbf6a9639164d12aabe572aab162c Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to

[Openvpn-devel] [S] Change in openvpn[master]: Improve peer fingerprint documentation

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/859?usp=email ) Change subject: Improve peer fingerprint documentation .. Improve peer fingerprint documentation - fix typo in peer-fingerprint - use ec_p

[Openvpn-devel] [S] Change in openvpn[master]: Improve peer fingerprint documentation

cron2 has uploaded a new patch set (#2) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/859?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: Improve peer fingerprint documentation

[Openvpn-devel] [PATCH applied] Re: Improve peer fingerprint documentation

No code change, so not much for me to test. Your patch has been applied to the master and release/2.6 branch (doc fix). commit cb9fdc8479a2744b9db95ef8ef97222ee86454fd (master) commit de127bd10c51cc946d42f9de8240a795f756ee4e (release/2.6) Author: Arne Schwabe Date: Tue Jan 14 14:49:09 2025 +010

[Openvpn-devel] [S] Change in openvpn[master]: Add more "intentional fallthrough" comments

Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/864?usp=email to look at the new patch set (#2). Change subject: Add more "intentional fallthrough" comments ...

[Openvpn-devel] [XS] Change in openvpn[master]: tls_crypt_v2_write_client_key_file: Fix missing-field-initializers co...

Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/867?usp=email to review the following change. Change subject: tls_crypt_v2_write_client_key_file: Fix missing-field-initializers compiler

[Openvpn-devel] [PATCH v1] Improve peer fingerpint documentation

From: Arne Schwabe - fix typo in peer-fingerprint - use ec_paramgen_curve instead of requiring a subshell Note: we still use -nodes instead of -noenc as it is more compatible. closes: issue #666 Change-Id: I9a12a0c127908af9f09d88fb3a493df3763d0cc5 Signed-off-by: Arne Schwabe Acked-by: Frank L

Re: [Openvpn-devel] [PATCH 1/1] console_systemd: remove the timeout when using `systemd-ask-password`

On Mon, Jan 13, 2025 at 12:44:48PM +0100, David Sommerseth via Openvpn-devel wrote: > Given the confirmation by Ben in this reply [1], I give this my ACK. I've > also double checked the git commit log in systemd to verify his finding. > > Acked-By: David Sommerseth > > > [1] >

[Openvpn-devel] [XS] Change in openvpn[master]: console_systemd: remove the timeout when using `systemd-ask-password`

Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/866?usp=email to review the following change. Change subject: console_systemd: remove the timeout when using `systemd-ask-password` .

[Openvpn-devel] [S] Change in openvpn[master]: Fix some trivial sign-compare compiler warnings

Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/865?usp=email to review the following change. Change subject: Fix some trivial sign-compare compiler warnings

[Openvpn-devel] [M] Change in openvpn[master]: Remove unused function check_subnet_conflict

Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/863?usp=email to review the following change. Change subject: Remove unused function check_subnet_conflict ...

[Openvpn-devel] [M] Change in openvpn[master]: Fix various compiler warnings for intentionally unused parameters

Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/861?usp=email to review the following change. Change subject: Fix various compiler warnings for intentionally unused parameters .

[Openvpn-devel] [M] Change in openvpn[master]: Remove various unused function parameters

Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/862?usp=email to review the following change. Change subject: Remove various unused function parameters ..

[Openvpn-devel] [S] Change in openvpn[master]: Add more "intentional fallthrough" comments

Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/864?usp=email to review the following change. Change subject: Add more "intentional fallthrough" comments

[Openvpn-devel] [S] Change in openvpn[master]: Improve peer fingerpint documentation

Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/859?usp=email ) Change subject: Improve peer fingerpint documentation .. Patch Set 1: Co

[Openvpn-devel] [M] Change in openvpn[master]: multi.c: add iroutes after dco peer is added

Attention is currently required from: flichtenheld, ordex, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/856?usp=email ) Change subject: multi.c: add iroutes after dco peer is added ...

[Openvpn-devel] [M] Change in openvpn[master]: multi.c: add iroutes after dco peer is added

Attention is currently required from: flichtenheld, ordex, stipa. Hello flichtenheld, ordex, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/856?usp=email to look at the new patch set (#2). The following approvals got outdated and were remo

[Openvpn-devel] [M] Change in openvpn[master]: dco-win: support for iroutes

Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/857?usp=email to look at the new patch set (#2). Change subject: dco-win: support for iroutes ..

[Openvpn-devel] [M] Change in openvpn[master]: ssl_openssl: Clean up unused functions and add missing "static"

Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/860?usp=email to review the following change. Change subject: ssl_openssl: Clean up unused functions and add missing "static"

[Openvpn-devel] [S] Change in openvpn[master]: Improve peer fingerpint documentation

Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/859?usp=email to review the following change. Change subject: Improve peer fingerpint documentation