Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/864?usp=email
to review the following change.
Change subject: Add more "intentional fallthrough" comments
......................................................................
Add more "intentional fallthrough" comments
To make it easier to exclude them from compiler
warnings.
Change-Id: I925accd8267f94ecfd9ccea85bae965dc2a10208
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M src/openvpn/list.c
M src/openvpn/push.c
2 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/64/864/1
diff --git a/src/openvpn/list.c b/src/openvpn/list.c
index 69f1510..b339c7b 100644
--- a/src/openvpn/list.c
+++ b/src/openvpn/list.c
@@ -437,34 +437,44 @@
{
case 11:
c += ((uint32_t) k[10] << 24);
+ /* Intentional [[fallthrough]]; */
case 10:
c += ((uint32_t) k[9] << 16);
+ /* Intentional [[fallthrough]]; */
case 9:
c += ((uint32_t) k[8] << 8);
+ /* Intentional [[fallthrough]]; */
/* the first byte of c is reserved for the length */
case 8:
b += ((uint32_t) k[7] << 24);
+ /* Intentional [[fallthrough]]; */
case 7:
b += ((uint32_t) k[6] << 16);
+ /* Intentional [[fallthrough]]; */
case 6:
b += ((uint32_t) k[5] << 8);
+ /* Intentional [[fallthrough]]; */
case 5:
b += k[4];
+ /* Intentional [[fallthrough]]; */
case 4:
a += ((uint32_t) k[3] << 24);
+ /* Intentional [[fallthrough]]; */
case 3:
a += ((uint32_t) k[2] << 16);
+ /* Intentional [[fallthrough]]; */
case 2:
a += ((uint32_t) k[1] << 8);
+ /* Intentional [[fallthrough]]; */
case 1:
a += k[0];
diff --git a/src/openvpn/push.c b/src/openvpn/push.c
index ddad109..06e421c 100644
--- a/src/openvpn/push.c
+++ b/src/openvpn/push.c
@@ -98,6 +98,7 @@
case AR_INTERACT:
ssl_purge_auth(false);
+ /* Intentional [[fallthrough]]; */
case AR_NOINTERACT:
/* SOFT-SIGTUSR1 -- Auth failure error */
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/864?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I925accd8267f94ecfd9ccea85bae965dc2a10208
Gerrit-Change-Number: 864
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
