[Openvpn-devel] [M] Change in openvpn[master]: Add building/testing with msbuild and the clang compiler

2024-12-26 Thread plaisthos (Code Review)
Attention is currently required from: cron2, flichtenheld, stipa. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/751?usp=email ) Change subject: Add building/testing with msbuild and the clang compiler ...

[Openvpn-devel] [M] Change in openvpn[master]: Add building/testing with msbuild and the clang compiler

2024-12-26 Thread plaisthos (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/751?usp=email to look at the new patch set (#6). Change subject: Add building/testing with msbuild and the clang

[Openvpn-devel] [XS] Change in openvpn[master]: Ensure that Python3 is available

2024-12-26 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, stipa. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/846?usp=email ) Change subject: Ensure that Python3 is available .. Patch Set 2:

[Openvpn-devel] [XS] Change in openvpn[master]: Ensure that Python3 is available

2024-12-26 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. Hello flichtenheld, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/846?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Co

[Openvpn-devel] [PATCH v3 2/2] port-share: Add proxy protocol v2 support

2024-12-26 Thread corubba via Openvpn-devel
In addition to the custom journal solution, also support the widely used binary PROXY protocol version 2 to convey the original client connection parameters to the proxy receiver. This makes the port-share journal feature more accessable and easier to use, because one doesn't need a custom integrat

Re: [Openvpn-devel] [PATCH v2 2/2] port-share: Add proxy protocol v2 support

2024-12-26 Thread corubba via Openvpn-devel
Hi, On 26.12.24 14:13, Gert Doering wrote: > On Mon, Dec 16, 2024 at 01:22:51PM +0100, corubba via Openvpn-devel wrote: >> In addition to the custom journal solution, also support the widely >> used binary PROXY protocol version 2 to convey the original client >> connection parameters to the proxy

Re: [Openvpn-devel] [PATCH v2 1/2] port-share: Normalize IPv4-mapped IPv6 addresses

2024-12-26 Thread corubba via Openvpn-devel
Hi, On 26.12.24 14:00, Gert Doering wrote: > On Wed, Dec 25, 2024 at 05:21:35PM +0100, Gert Doering wrote: >> I'm fine with the idea, but I do not like the implementation with >> "yet another localized sockaddr manipulation function" - we already >> have similar code in socket.c/setenv_sockaddr(),

[Openvpn-devel] [M] Change in openvpn[master]: Add building/testing with msbuild and the clang compiler

2024-12-26 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/751?usp=email ) Change subject: Add building/testing with msbuild and the clang compiler ...

Re: [Openvpn-devel] [PATCH v2 2/2] port-share: Add proxy protocol v2 support

2024-12-26 Thread Gert Doering
Hi, On Mon, Dec 16, 2024 at 01:22:51PM +0100, corubba via Openvpn-devel wrote: > In addition to the custom journal solution, also support the widely > used binary PROXY protocol version 2 to convey the original client > connection parameters to the proxy receiver. This makes the port-share > journ

Re: [Openvpn-devel] [PATCH v2 1/2] port-share: Normalize IPv4-mapped IPv6 addresses

2024-12-26 Thread Gert Doering
Hi, On Wed, Dec 25, 2024 at 05:21:35PM +0100, Gert Doering wrote: > I'm fine with the idea, but I do not like the implementation with > "yet another localized sockaddr manipulation function" - we already > have similar code in socket.c/setenv_sockaddr(), so maybe we need > to make this a more gen

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2024-12-26 Thread stipa (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email ) Change subject: dns: support multiple domains without DHCP .

[Openvpn-devel] [M] Change in openvpn[master]: Add building/testing with msbuild and the clang compiler

2024-12-26 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/751?usp=email ) Change subject: Add building/testing with msbuild and the clang compiler ..

[Openvpn-devel] [XS] Change in openvpn[master]: Ensure that Python3 is available

2024-12-26 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/846?usp=email ) Change subject: Ensure that Python3 is available .. Patch Set 1:

[Openvpn-devel] [M] Change in openvpn[master]: Add building/testing with msbuild and the clang compiler

2024-12-26 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/751?usp=email ) Change subject: Add building/testing with msbuild and the clang compiler ..