Hi, On Mon, Dec 16, 2024 at 01:22:51PM +0100, corubba via Openvpn-devel wrote: > In addition to the custom journal solution, also support the widely > used binary PROXY protocol version 2 to convey the original client > connection parameters to the proxy receiver. This makes the port-share > journal feature more accessable and easier to use, because one doesn't > need a custom integration. > > While this is a spec-compliant sender implementation of the PROXY > protocol, it does not implement it in full. Version 1 was left out > entirely, in favour of the superior and easier-to-implement version 2. > The implementation was also kept minimal with regards to what OpenVPN > supports/requires: Local commands, unix sockets, UDP and TLVs are not > implemented.
Are there any reference URLs for the PROXY protocol? If yes, I think it
would be good to include a reference into one of the comments - the next
person to read that code would then know which document this is based on.
Besides this, I'm not sure what to do with these
> + ASSERT(4 >= sizeof(src.addr.in4.sin_addr));
> + ASSERT(4 >= sizeof(dst.addr.in4.sin_addr));
> + memcpy(&header[16], &src.addr.in4.sin_addr,
> sizeof(src.addr.in4.sin_addr));
> + memcpy(&header[20], &dst.addr.in4.sin_addr,
> sizeof(dst.addr.in4.sin_addr));
... this is all obviously correct, but it feels heavy handed, and many
lines of code... (especially 2x sizeof on the same structure element)
I think we can fairly safely assume that an in4.sin_addr will always be
4 bytes, an in4.sin_port will always be 2 bytes, and an IPv6 address will
always be 16 bytes... so I wonder if it wouln't be easier to just copy
a well-known number of bytes (openvpn_sockaddr is also "always bigger
than that", so no read overrun) here.
I know that "magic numbers" in code are considered a bad pattern, but
these things are really constant length, and the buffer layout *requires*
"exactly 4" and "exactly 2" bytes...
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
