[Openvpn-devel] [M] Change in openvpn[master]: Trigger renegotiation of data key if getting close to the AEAD usage ...

2024-11-28 Thread plaisthos (Code Review)
Attention is currently required from: cron2, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/796?usp=email ) Change subject: Trigger renegotiation of data key if getting close to the AEAD usage limit ...

[Openvpn-devel] [M] Change in openvpn[master]: Trigger renegotiation of data key if getting close to the AEAD usage ...

2024-11-28 Thread plaisthos (Code Review)
Attention is currently required from: cron2, flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/796?usp=email to look at the new patch set (#7). Change subject: Trigger renegotiation of data key if getting close to the

[Openvpn-devel] [M] Change in openvpn[master]: Trigger renegotiation of data key if getting close to the AEAD usage ...

2024-11-28 Thread plaisthos (Code Review)
Attention is currently required from: cron2, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/796?usp=email ) Change subject: Trigger renegotiation of data key if getting close to the AEAD usage limit ...

[Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Allow OpenVPN in client mode to receive and handle PUSH ...

2024-11-28 Thread mrbff (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. mrbff has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/808?usp=email ) Change subject: PUSH_UPDATE: Allow OpenVPN in client mode to receive and handle PUSH UPDATE control messages to allow options u

[Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Allow OpenVPN in client mode to receive and handle PUSH ...

2024-11-28 Thread mrbff (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/808?usp=email to look at the new patch set (#6). Change subject: PUSH_UPDATE: Allow OpenVPN in client

[Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Allow OpenVPN in client mode to receive and handle PUSH ...

2024-11-28 Thread mrbff (Code Review)
Attention is currently required from: flichtenheld, mrbff, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/808?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed

[Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Allow OpenVPN in client mode to receive and handle PUSH ...

2024-11-28 Thread mrbff (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. mrbff has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/808?usp=email ) Change subject: PUSH_UPDATE: Allow OpenVPN in client mode to receive and handle PUSH UPDATE control messages to allow options u

[Openvpn-devel] [M] Change in openvpn[master]: Haiku: Add calls to manage routing table

2024-11-28 Thread kallisti5 (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. kallisti5 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/688?usp=email ) Change subject: Haiku: Add calls to manage routing table ...

[Openvpn-devel] [M] Change in openvpn[master]: Haiku: Add calls to manage routing table

2024-11-28 Thread kallisti5 (Code Review)
Attention is currently required from: cron2, flichtenheld, kallisti5, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/688?usp=email to look at the new patch set (#11). Change subject: Haiku: Add calls

[Openvpn-devel] [S] Change in openvpn[master]: macOS: Assume that net/if_utun.h is always present

2024-11-28 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/823?usp=email ) Change subject: macOS: Assume that net/if_utun.h is always present .. macOS: Assume that net/if_utun.h is always present Has been present

[Openvpn-devel] [S] Change in openvpn[master]: macOS: Assume that net/if_utun.h is always present

2024-11-28 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/823?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: macOS: Assume that net/if_utun.h is always present

[Openvpn-devel] [PATCH applied] Re: macOS: Assume that net/if_utun.h is always present

2024-11-28 Thread Gert Doering
This is, basically, a "stare at code and do build test via GHA" patch - which succeeds. It came out of a discussion on brackets in #821, and getting rid of an #ifdef is always good ;-) Your patch has been applied to the master branch. As discussed on IRC, part of the change was an "uncrustify do

[Openvpn-devel] [PATCH v1] macOS: Assume that net/if_utun.h is always present

2024-11-28 Thread Gert Doering
From: Frank Lichtenheld Has been present in all releases since 10.7, i.e. about 13 years ago. At this point the check just makes the code uglier for no actual benefit. Change-Id: I41eeae35ab23d9fb2512f33086f20f54c2d4f6df Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe --- This change

[Openvpn-devel] [S] Change in openvpn[master]: macOS: Assume that net/if_utun.h is always present

2024-11-28 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/823?usp=email ) Change subject: macOS: Assume that net/if_utun.h is always present .. Pa

[Openvpn-devel] [S] Change in openvpn[master]: Fix some formatting related to if/else and macros

2024-11-28 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/821?usp=email to look at the new patch set (#3). Change subject: Fix some formatting related to if/else and macros .

[Openvpn-devel] [S] Change in openvpn[master]: macOS: Assume that net/if_utun.h is always present

2024-11-28 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/823?usp=email to review the following change. Change subject: macOS: Assume that net/if_utun.h is always present .

[Openvpn-devel] [PATCH applied] Re: Various typo fixes

2024-11-28 Thread Gert Doering
Your patch has been applied to the master and release/2.6 branch. commit f626b661dba0838907f6ad3b46cb4db5f00d1c9a (master) commit 2776810696bf8a56525ac7a2765c3d3f2ac9d23e (release/2.6) Author: Frank Lichtenheld Date: Thu Nov 28 13:30:16 2024 +0100 Various typo fixes Signed-off-by: Fr

[Openvpn-devel] [S] Change in openvpn[master]: Various typo fixes

2024-11-28 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#3) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/822?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Various typo fixes

[Openvpn-devel] [S] Change in openvpn[master]: Various typo fixes

2024-11-28 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/822?usp=email ) Change subject: Various typo fixes .. Various typo fixes This collects some minor typo fixes that are not worth each their own commit. Fi

[Openvpn-devel] [PATCH v2] Various typo fixes

2024-11-28 Thread Gert Doering
From: Frank Lichtenheld This collects some minor typo fixes that are not worth each their own commit. Fixes: OpenVPN/openvpn#644 Fixes: OpenVPN/openvpn#442 Change-Id: Ifad21a2841e97e910775f3618ddac1c483d74b65 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering --- This change was reviewe

[Openvpn-devel] [S] Change in openvpn[master]: Fix some formatting related to if/else and macros

2024-11-28 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/821?usp=email to look at the new patch set (#2). Change subject: Fix some formatting related to if/else and macros .

[Openvpn-devel] [S] Change in openvpn[master]: Various typo fixes

2024-11-28 Thread flichtenheld (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello cron2, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/822?usp=email to look at the new patch set (#2). The change is no longer submittable: checks~ChecksSubmitRule is uns

[Openvpn-devel] [S] Change in openvpn[master]: Various typo fixes

2024-11-28 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/822?usp=email ) Change subject: Various typo fixes .. Patch Set 1: Code-Review+2

[Openvpn-devel] [S] Change in openvpn[master]: Fix some formatting related to if/else and macros

2024-11-28 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/821?usp=email to review the following change. Change subject: Fix some formatting related to if/else and macros ..

[Openvpn-devel] [S] Change in openvpn[master]: Various typo fixes

2024-11-28 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/822?usp=email to review the following change. Change subject: Various typo fixes .

[Openvpn-devel] [S] Change in openvpn[master]: Haiku: Introduce basic platform / tun support

2024-11-28 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/687?usp=email ) Change subject: Haiku: Introduce basic platform / tun support .. Haiku: Introduce basic platform / tun support * Special thanks to Sean Br

[Openvpn-devel] [S] Change in openvpn[master]: Haiku: Introduce basic platform / tun support

2024-11-28 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#7) to the change originally created by kallisti5. ( http://gerrit.openvpn.net/c/openvpn/+/687?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Haiku: Introduce basic platform / tun support

[Openvpn-devel] [PATCH applied] Re: Haiku: Introduce basic platform / tun support

2024-11-28 Thread Gert Doering
Thanks for your contribution, and congratulations to having the first half of HAIKU support in OpenVPN :-) I have no Haiku test system (yet...), so I have only looked at the change - in which ways will it affect other systems, does it follow our guidelines for formatting & buffer management, etc -

[Openvpn-devel] [PATCH v6] Haiku: Introduce basic platform / tun support

2024-11-28 Thread Gert Doering
From: Alexander von Gluck * Special thanks to Sean Brady's hard work in GSoC 2023 towards creating a TUN/TAP driver for Haiku! * More kudos to Augustin Cavalier for making it functional :-) Signed-off-by: Alexander von Gluck Acked-by: Gert Doering Change-Id: I9a278374f492a538f0c174ced1746c3b

[Openvpn-devel] [S] Change in openvpn[master]: Haiku: Introduce basic platform / tun support

2024-11-28 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, kallisti5, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/687?usp=email ) Change subject: Haiku: Introduce basic platform / tun support ..

[Openvpn-devel] [L] Change in openvpn[master]: Implement HKDF expand function based on RFC 8446

2024-11-28 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/798?usp=email ) Change subject: Implement HKDF expand function based on RFC 8446 .. Patc

[Openvpn-devel] [M] Change in openvpn[master]: Trigger renegotiation of data key if getting close to the AEAD usage ...

2024-11-28 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/796?usp=email ) Change subject: Trigger renegotiation of data key if getting close to the AEAD usage limit ...

[Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Allow OpenVPN in client mode to receive and handle PUSH ...

2024-11-28 Thread flichtenheld (Code Review)
Attention is currently required from: mrbff, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/808?usp=email ) Change subject: PUSH_UPDATE: Allow OpenVPN in client mode to receive and handle PUSH UPDATE control messages to allow options updating

[Openvpn-devel] [M] Change in openvpn[master]: Trigger renegotiation of data key if getting close to the AEAD usage ...

2024-11-28 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/796?usp=email ) Change subject: Trigger renegotiation of data key if getting close to the AEAD usage limit ...