[Openvpn-devel] [M] Change in openvpn[master]: Static-challenge concatenation option

2024-07-09 Thread selvanair (Code Review)
Attention is currently required from: flichtenheld, plaisthos. selvanair has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/665?usp=email ) Change subject: Static-challenge concatenation option .. Patc

[Openvpn-devel] [M] Change in openvpn[master]: Static-challenge concatenation option

2024-07-09 Thread selvanair (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/665?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-

[Openvpn-devel] [S] Change in openvpn[master]: Add test for static-challenge concatenation option

2024-07-09 Thread flichtenheld (Code Review)
Attention is currently required from: selvanair. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/666?usp=email ) Change subject: Add test for static-challenge concatenation option .. Pa

[Openvpn-devel] [M] Change in openvpn[master]: Allow trailing \r and \n in control channel message

2024-07-09 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/672?usp=email ) Change subject: Allow trailing \r and \n in control channel message ...

[Openvpn-devel] [M] Change in openvpn[master]: Allow trailing \r and \n in control channel message

2024-07-09 Thread plaisthos (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/672?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Co

[Openvpn-devel] [XS] Change in openvpn[master]: configure: Switch to C11 by default

2024-07-09 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/673?usp=email ) Change subject: configure: Switch to C11 by default .. Patch Set 1: Code

[Openvpn-devel] [XS] Change in openvpn[master]: configure: Switch to C11 by default

2024-07-09 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/673?usp=email to review the following change. Change subject: configure: Switch to C11 by default

[Openvpn-devel] [M] Change in openvpn[master]: Static-challenge concatenation option

2024-07-09 Thread selvanair (Code Review)
Attention is currently required from: flichtenheld, plaisthos. selvanair has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/665?usp=email ) Change subject: Static-challenge concatenation option .. Patc

[Openvpn-devel] [M] Change in openvpn[master]: Ensures all params are ready before invoking dco_set_peer()

2024-07-09 Thread flichtenheld (Code Review)
Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/587?usp=email ) Change subject: Ensures all params are ready before invoking dco_set_peer() ...

[Openvpn-devel] [M] Change in openvpn[master]: Static-challenge concatenation option

2024-07-09 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, selvanair. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/665?usp=email ) Change subject: Static-challenge concatenation option .. Patc

Re: [Openvpn-devel] [PATCH 2/5] sample/sample-plugins/defer/multi-auth.c: handle strdup errors

2024-07-09 Thread Frank Lichtenheld
On Mon, Jul 08, 2024 at 11:08:19PM +0200, Ilia Shipitsin wrote: > Signed-off-by: Ilia Shipitsin > --- > sample/sample-plugins/defer/multi-auth.c | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/sample/sample-plugins/defer/multi-auth.c > b/sample/sample-plugins/defer/mul

Re: [Openvpn-devel] [PATCH 5/5] tests/unit_tests/openvpn/test_auth_token.c: handle strdup errors

2024-07-09 Thread Frank Lichtenheld
On Mon, Jul 08, 2024 at 11:08:22PM +0200, Ilia Shipitsin wrote: > Signed-off-by: Ilia Shipitsin > --- > tests/unit_tests/openvpn/test_auth_token.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/unit_tests/openvpn/test_auth_token.c > b/tests/unit_tests/openvpn/test_auth_token.c