Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/587?usp=email )
Change subject: Ensures all params are ready before invoking dco_set_peer() ...................................................................... Patch Set 1: Code-Review-1 (2 comments) File src/openvpn/ssl.h: http://gerrit.openvpn.net/c/openvpn/+/587/comment/9b3ef809_11ff49e8 : PS1, Line 456: * whenever a crypto param update occur. Nitpick: occurs File src/openvpn/ssl.c: http://gerrit.openvpn.net/c/openvpn/+/587/comment/2a154988_9c01f88f : PS1, Line 1629: ret = dco_set_peer(dco, Nitpick: no reason not to move the "int" here. ret is not used outside this if -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/587?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic8538e734dba53cd43fead3961e4401c8037e079 Gerrit-Change-Number: 587 Gerrit-PatchSet: 1 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Comment-Date: Tue, 09 Jul 2024 13:01:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
