[Openvpn-devel] [XL] Change in openvpn[master]: Lay the foundation to support both old and new versions of DCO

2024-06-26 Thread flichtenheld (Code Review)
Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/662?usp=email ) Change subject: Lay the foundation to support both old and new versions of DCO

[Openvpn-devel] [S] Change in openvpn[master]: configure: Try to detect LZO with pkg-config

2024-06-26 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#9) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/556?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: configure: Try to detect LZO with pkg-config ..

[Openvpn-devel] [S] Change in openvpn[master]: configure: Try to detect LZO with pkg-config

2024-06-26 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/556?usp=email ) Change subject: configure: Try to detect LZO with pkg-config .. configure: Try to detect LZO with pkg-config On most systems this should w

[Openvpn-devel] [PATCH applied] Re: configure: Try to detect LZO with pkg-config

2024-06-26 Thread Gert Doering
Detailed test reports are in the gerrit notes... so not repeating them here :-) - but finally, we have something that just detects LZO "wherever it is", as long as a pkg-config entry is there - the need to have LZO_CFLAGS/LZO_LIBS on all the *BSDs has irked me since 2.1 or so... (thanks!) Sanity

[Openvpn-devel] [PATCH v8] configure: Try to detect LZO with pkg-config

2024-06-26 Thread Frank Lichtenheld
On most systems this should work just fine. v2: - simplify code by removing -llzo special handling v3: - reintroduce support for autodetection without pkg-config, no need to break backwards compatibility right now v7: - Handle case correctly where lzo/lzo1x.h can not be included at all. O

[Openvpn-devel] [S] Change in openvpn[master]: configure: Try to detect LZO with pkg-config

2024-06-26 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/556?usp=email ) Change subject: configure: Try to detect LZO with pkg-config .. P

[Openvpn-devel] [S] Change in openvpn[master]: configure: Try to detect LZO with pkg-config

2024-06-26 Thread cron2 (Code Review)
Attention is currently required from: plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/556?usp=email ) Change subject: configure: Try to detect LZO with pkg-config .. Patch Set 8: Co

[Openvpn-devel] [S] Change in openvpn[master]: configure: Try to detect LZO with pkg-config

2024-06-26 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/556?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Code-

[Openvpn-devel] IRC community meeting summary

2024-06-26 Thread Johan Draaisma
Meeting summary for 26 June 2024: * *New: release openvpn 2.6.12* /The security issue addressed in 2.6.11 has the known issue that it breaks certain setups with backend scripts that produce custom auth_failed messages./ /This will be addressed in the upcoming 2.6.12 release./ /An

[Openvpn-devel] [S] Change in openvpn[master]: configure: Try to detect LZO with pkg-config

2024-06-26 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/556?usp=email ) Change subject: configure: Try to detect LZO with pkg-config .. P

[Openvpn-devel] [M] Change in openvpn[master]: t_server_null: multiple improvements and fixes

2024-06-26 Thread flichtenheld (Code Review)
Attention is currently required from: mattock, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/669?usp=email ) Change subject: t_server_null: multiple improvements and fixes ..

[Openvpn-devel] [M] Change in openvpn[master]: Http-proxy: fix bug preventing proxy credentials caching

2024-06-26 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/523?usp=email ) Change subject: Http-proxy: fix bug preventing proxy credentials caching .. Http-proxy: fix bug preventing proxy credentials caching Cachi

[Openvpn-devel] [M] Change in openvpn[master]: Http-proxy: fix bug preventing proxy credentials caching

2024-06-26 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#11) to the change originally created by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/523?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Http-proxy: fix bug preventing proxy credentials caching

[Openvpn-devel] [PATCH applied] Re: Http-proxy: fix bug preventing proxy credentials caching

2024-06-26 Thread Gert Doering
The original ACK came from Frank, I'm just ACKing the change v8 -> v10 (rebased, and add (void) to function declaration / prototypes where missing). I do not have a test setup to properly test this right now - I do have proxies, but they do not need auth, and especially the "cache on reconnect" ne