Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/556?usp=email )
Change subject: configure: Try to detect LZO with pkg-config
......................................................................
Patch Set 7: Code-Review+2
(2 comments)
Patchset:
PS6:
> close... […]
I think the pc is broken... everything LZO itself includes uses
<lzo/lzoconf.h>... but it's the same (`Cflags: -I${includedir}/lzo`) on
gentoo... where it just happens to work because `/usr/include` is in the
include path anyway. Gah.
Patchset:
PS7:
Tested on FreeBSD 14, "configure with no option" -> succeeds & builds fine (LZO
in /usr/local/..., make using `-I/usr/local/include/lzo -I/usr/local/include`
because that's where cmocka and lz4 are living). Disabling LZ4 makes
compilation succeed with only `-I/usr/local/include/lzo`. This is good :-)
All the buildbots still succeed, which means this hasn't broken explicitly
setting "whatever we used before".
oi2024 has lzo in `/usr/include/`, so, boring case.
obsd75 has lzo in `/usr/local/include/lzo`, patched configure works, compile
works. With `--disable-lz4` there is no mention of `-I/usr/local/include`
anymore, and it still succeeds ;-)
nbsd81 has `/usr/pkg/include/lzo/` and the patched configure finds it fine, and
then barfs on
```
configure:18379: checking for lzo1x.h
configure:18379: gcc -c -g -O2 -std=c99 -I/usr/pkg/include/lzo conftest.c >&5
In file included from conftest.c:136:0:
/usr/pkg/include/lzo/lzodefs.h:1035:6: error: #error "unexpected configuration -
check your compiler defines"
# error "unexpected configuration - check your compiler defines"
^
```
which is something weird about UINT_MAX testing against LZO_0xffffffffL. Not
sure how to fix that. It does not break on the buildbot as that one has a
symlink from `/usr/include/lzo -> /usr/pkg/include/lzo` (to apease older source
trees) - with that, the configure change works fine. Without, it bombs. I
would still tend to progress the patch, unless someone has a good idea how to
tackle this...
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/556?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1c038dc4ec80d3499582d81eee61fee74f26e693
Gerrit-Change-Number: 556
Gerrit-PatchSet: 7
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Wed, 26 Jun 2024 12:29:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: cron2 <[email protected]>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
