[Openvpn-devel] [S] Change in openvpn[master]: Log OpenSSL errors on failure to set certificate

2023-10-01 Thread selvanair (Code Review)
Attention is currently required from: flichtenheld. selvanair has removed a vote from this change. ( http://gerrit.openvpn.net/c/openvpn/+/363?usp=email ) Change subject: Log OpenSSL errors on failure to set certificate .. Re

[Openvpn-devel] [S] Change in openvpn[master]: Log OpenSSL errors on failure to set certificate

2023-10-01 Thread selvanair (Code Review)
Attention is currently required from: flichtenheld. selvanair has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/363?usp=email ) Change subject: Log OpenSSL errors on failure to set certificate .. Patc

[Openvpn-devel] [S] Change in openvpn[master]: Log OpenSSL errors on failure to set certificate

2023-10-01 Thread selvanair (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/363?usp=email to look at the new patch set (#2). Change subject: Log OpenSSL errors on failure to set certificate ...

[Openvpn-devel] [S] Change in openvpn[master]: Log OpenSSL errors on failure to set certificate

2023-10-01 Thread selvanair (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/363?usp=email to review the following change. Change subject: Log OpenSSL errors on failure to set certificate .

[Openvpn-devel] [PATCH] Log OpenSSL errors on failure to set certificate

2023-10-01 Thread selva . nair
From: Selva Nair Currently we log a bogus error message saying private key password verification failed when SSL_CTX_use_cert_and_key() fails in pkcs11_openssl.c. Instead print OpenSSL error queue and exit promptly. Also log OpenSSL errors when SSL_CTX_use_certiifcate() fails in cryptoapi.c and

[Openvpn-devel] [S] Change in openvpn[master]: Change type of frame.mss_fix to uint16_t

2023-10-01 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/268?usp=email ) Change subject: Change type of frame.mss_fix to uint16_t .. Patch