Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/268?usp=email )
Change subject: Change type of frame.mss_fix to uint16_t ...................................................................... Patch Set 3: (2 comments) File src/openvpn/mss.c: http://gerrit.openvpn.net/c/openvpn/+/268/comment/94038c59_cb6b931f : PS3, Line 195: mssval += opt[3]; why is this change needed? File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/268/comment/817b1791_91077f03 : PS3, Line 7257: if (mssfix > UINT16_MAX) If we introduce a check here, we should also ensure a minimum value - we assign `ce.mssfix-40` to `frame->mss_fix`, which is (now) unsigned, so the result will be something huge for values 1..39, and 0 for `--mssfix 40`. For IPv6, only values >= 60 make sense. Now, the code in `mss_fixup_dowork()` won't adjust a given mss upwards, but it's still kind of unexpected behaviour... -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/268?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Id8321dfbb8ad8d79f4bb2a9da61f8cd6b6c6ee26 Gerrit-Change-Number: 268 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Sun, 01 Oct 2023 12:02:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
