[Openvpn-devel] [PATCH v3 10/25] dco: periodically check and possibly rotate/delete keys

2022-08-02 Thread Antonio Quartulli
Data channel keys are periodically regenarated and installed in ovpn-dco. However, there is a certain moment when keys are rotated in order to elect the new primary one. Check the key status in userspace so that kernelspace can be informed as well when rotations happen. Signed-off-by: Antonio Qua

[Openvpn-devel] [PATCH applied] Re: Cleanup receive_auth_failed and simplify method

2022-08-02 Thread Gert Doering
As Frank said, "best viewed with diff -w" :-) - the cleanup bits are also straightforward. I do not have a good test case for this - but my usual client tests with "expect AUTH_FAILED..." all pass. Your patch has been applied to the master branch. commit 88823adebac31958cee83572241cff9fc775a601

[Openvpn-devel] [PATCH v2] dco: move availability check to the end of check_option_conflict() function

2022-08-02 Thread Antonio Quartulli
To better arrange the order DCO option conflict messages are printed, we decided to first perform all needed checks on provided options and, only at the end, if no conflict was detected, to check if DCO is really available on the system. This way a user gets prompted with all warnings about their

Re: [Openvpn-devel] [PATCH] Make build deterministic, remove __DATE__

2022-08-02 Thread Gert Doering
Hi, On Mon, Dec 13, 2021 at 05:28:41PM +0100, Frank Lichtenheld wrote: > The information provided by this is minimal > and it makes it more difficult to provide > deterministic builds. There are work-arounds > for that but I think it is easier to just remove > it completely. > > Allows the build

[Openvpn-devel] [PATCH applied] Re: Allow a few levels of recursion in virtual_output_callback()

2022-08-02 Thread Gert Doering
Acked-by: Gert Doering I cannot test this (beyond "compile", but that is trivial) but the description in https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24738.html makes sense, so allowing "a limited amount" of recursion plus actually logging when this is hit should make m

[Openvpn-devel] [PATCH applied] Re: Do not skip ERROR:/SUCCESS: response from management interface

2022-08-02 Thread Gert Doering
I'm not sure I understand what is happening here, exactly, but since Arne understands management way better and ACKed this - in it goes :) (it *looks* harmless enough). Since I understand this to be a bugfix, applied to 2.5 as well. Your patch has been applied to the master and release/2.5 branch

Re: [Openvpn-devel] [PATCH v2 11/25] dco: split option parsing routines

2022-08-02 Thread Gert Doering
Hi, On Thu, Jul 28, 2022 at 09:47:33PM +0200, Antonio Quartulli wrote: > DCO will try to install keys upon generating them, however, this happens > when parsing pushed cipher options (due to NCP). > > For this reason we need to postpone parsing pushed cipher options to *after* > the tunnel interf

[Openvpn-devel] [PATCH] dco: move availability check to the end of check_option_conflict() function

2022-08-02 Thread Antonio Quartulli
To better arrange the order DCO option conflict messages are printed, we decided to first perform all needed checks on provided options and, only at the end, if no conflict was detected, to check if DCO is really available on the system. This way a user gets prompted with all warnings about their

Re: [Openvpn-devel] [PATCH v2 10/25] dco: periodically check and possibly rotate/delete keys

2022-08-02 Thread Antonio Quartulli
Hi, On 01/08/2022 17:44, Frank Lichtenheld wrote: On Thu, Jul 28, 2022 at 09:35:42PM +0200, Antonio Quartulli wrote: Data channel keys are periodically regenarated and installed in ovpn-dco. However, there is a certain moment when keys are rotated in order to elect the new primary one. Check t