Hi,

On Mon, Dec 13, 2021 at 05:28:41PM +0100, Frank Lichtenheld wrote:
> The information provided by this is minimal
> and it makes it more difficult to provide
> deterministic builds. There are work-arounds
> for that but I think it is easier to just remove
> it completely.
> 
> Allows the build to pass with -Wdate-time -Werror.
> 
> Signed-off-by: Frank Lichtenheld <fr...@lichtenheld.com>

I see that this patch has two ACKs, but I feel I'd lose visibility
into my heap of test binaries all over the place.

OTOH, I do see the argument about deterministic (release) builds.

What we already do today is to include the git commit ID *iff* this
is built from git into CONFIGURE_GIT_REVISION (version.h) - maybe
this could be done in a similar way?

 - if there is no .git around (and/or $condition?), build without
   commit ID and no build date

 - if there is, add build date + git revision to "openvpn --version"

gert

-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             g...@greenie.muc.de

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to