[Openvpn-devel] Tips for testing

2022-04-08 Thread Pete Nelson
Hello, devs. I'm looking for tips on testing a dev branch of openvpn. I see I can fork the github repo and enable actions to test that it builds on various OSs, but what do you guys do for functional testing? Do you run a bunch of VMs or docker containers and have them connect to each other? Any

[Openvpn-devel] [PATCH applied] Re: t_net.sh: delete dummy iface using iproute command

2022-04-08 Thread Gert Doering
Acked-by: Gert Doering Indeed, now t_net.sh properly cleans up behind itself :-) - thanks. Your patch has been applied to the master and release/2.5 branch. commit 976e6caf0e161d3c787e1378cec44608c17b292a (master) commit c3f4419cd37faaf4f2960d911a1008a161b82561 (release/2.5) Author: Antonio Qua

Re: [Openvpn-devel] [PATCH v3] platform: Retain CAP_NET_ADMIN when dropping privileges

2022-04-08 Thread Antonio Quartulli
Hi, On 08/04/2022 13:18, Timo Rothenpieler wrote: This one does not really look like it should be in "fallback:" - because that way it always gets called, even if we jump there right at function entry, if keep_caps == 0. No, it's intentional. It ensures that it's printed even if we don't HAVE

Re: [Openvpn-devel] [PATCH v3] platform: Retain CAP_NET_ADMIN when dropping privileges

2022-04-08 Thread Timo Rothenpieler
On 08/04/2022 11:35, Gert Doering wrote: Hi, On Thu, Apr 07, 2022 at 08:40:24PM +0200, Timo Rothenpieler wrote: +else if (res < 0) +{ +if (res == -3) +{ +msg(M_NONFATAL, "Following error likely due to missing capability CAP_SETPCAP."); +} +ms

[Openvpn-devel] [PATCH applied] Re: networking: implement net_iface_new and net_iface_del APIs

2022-04-08 Thread Gert Doering
Acked-by: Gert Doering I like the new style much more - thanks (and it's actually quite a few less lines of code - good that we're not paid *cough* by LoC produced). I have fixed one indent that uncrustify complained about - second line of the net_iface_new() function declaration in networking_i

Re: [Openvpn-devel] 2.6 Release plan

2022-04-08 Thread Gert Doering
Hi, On Fri, Apr 08, 2022 at 05:50:49PM +0800, yuanxun wrote: > When will openvpn 2.6 with dco be released? What is the plan for the dco > version? It's done when it's done. The initial plan was "around end of March", but it seems we did not make "March 2022". I am currently working my way throu

Re: [Openvpn-devel] 2.6 Release plan

2022-04-08 Thread Arne Schwabe
Am 08.04.22 um 11:50 schrieb yuanxun: Hi! When will openvpn 2.6 with dco be released? In the future. We do not commit to fixed dates. What is the plan for the dco version? Release it in the future as part of OpenVPN 2.6. If you need it now, feel free to use the master and/or dco branch.

[Openvpn-devel] 2.6 Release plan

2022-04-08 Thread yuanxun
Hi! When will openvpn 2.6 with dco be released? What is the plan for the dco version? ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH v3] platform: Retain CAP_NET_ADMIN when dropping privileges

2022-04-08 Thread Gert Doering
Hi, On Thu, Apr 07, 2022 at 08:40:24PM +0200, Timo Rothenpieler wrote: > +else if (res < 0) > +{ > +if (res == -3) > +{ > +msg(M_NONFATAL, "Following error likely due to missing > capability CAP_SETPCAP."); > +} > +msg(err_flags | M_ERRNO, "capn