Acked-by: Gert Doering <g...@greenie.muc.de>
I like the new style much more - thanks (and it's actually quite a few
less lines of code - good that we're not paid *cough* by LoC produced).
I have fixed one indent that uncrustify complained about - second line
of the net_iface_new() function declaration in networking_iproute2.c
(but not in networking_sitnl.c). Your editor fighting the whitespace
dragon?
On the actual code change - this is not doing much yet, as t_net.sh
isn't even calling it yet... - but calling "networking_testdriver"
manually, I see that it creates an interface, and then removes it
again, for SITNL builds. For IPROUTE2 builds, the testdriver is
not built (and not trivial to do), so I did not test that one,
but "it looks correct".
Your patch has been applied to the master branch.
commit c838a9f98fa2d8b6d7b2658e8399bc9d19ec60e0
Author: Antonio Quartulli
Date: Thu Apr 7 11:41:46 2022 +0200
networking: implement net_iface_new and net_iface_del APIs
Signed-off-by: Arne Schwabe <a...@rfc2549.org>
Signed-off-by: Antonio Quartulli <a...@unstable.cc>
Acked-by: Gert Doering <g...@greenie.muc.de>
Message-Id: <20220407094146.7684-...@unstable.cc>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24088.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
