Re: [Openvpn-devel] [PATCH] Fix leaks in route.

Hi, On 14/07/2021 18:25, David Korczynski wrote: > Signed-off-by: David Korczynski Some commit message is always good - just to give context to the reader without the need to look at the rest of the code. But if Gert is fine without it, I am fine too. > --- > src/openvpn/route.c | 2 ++ > 1 f

[Openvpn-devel] [PATCH] Fix leaks in route.

Signed-off-by: David Korczynski --- src/openvpn/route.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/openvpn/route.c b/src/openvpn/route.c index 56fa7717..e429e8c0 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -1584,6 +1584,7 @@ add_route(struct route_ipv4 *r, i

Re: [Openvpn-devel] [PATCH] Avoid leak in add_route.

Hi, On Wed, Jul 14, 2021 at 02:46:42PM +0100, David Korczynski wrote: > Signed-off-by: David Korczynski This is good :-) > --- > src/openvpn/route.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/openvpn/route.c b/src/openvpn/route.c > index 3b2af8b4..e429e8c0 100644 > --- a/src

[Openvpn-devel] [PATCH] Avoid leak in add_route.

Signed-off-by: David Korczynski --- src/openvpn/route.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/openvpn/route.c b/src/openvpn/route.c index 3b2af8b4..e429e8c0 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -1584,6 +1584,7 @@ add_route(struct route_ipv4 *r, if

Re: [Openvpn-devel] [PATCH] fix memory leak in add_route_ipv6.

Hi, thanks for the patch. Well spotted :-) Two things: - I see that the code in add_route() is the same... struct argv argv = argv_new(); ... if (!(r->flags & RT_DEFINED)) { return; } so while at it, please send a fix for both places - if you want, please set you

[Openvpn-devel] [PATCH] fix memory leak in add_route_ipv6.

--- src/openvpn/route.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/openvpn/route.c b/src/openvpn/route.c index 56fa7717..3b2af8b4 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -1891,6 +1891,7 @@ add_route_ipv6(struct route_ipv6 *r6, const struct tuntap *tt, if (

[Openvpn-devel] Summary of the community meeting (14th July 2021)

Hi, Here's the summary of the IRC meeting. --- COMMUNITY MEETING Place: #openvpn-meeting on libera.chat Date: Wed 14th July 2021 Time: 14:00 CET (12:00 UTC) Planned meeting topics for this meeting were here: Your local meeting

[Openvpn-devel] [PATCH applied] Re: Introduce S_GENERATED_KEYS state and generate keys only when authenticated

Acked-by: Gert Doering Adding my ACK on v3 to Antonio's test report on v3 and ACK on v2. v3 is really exactly identical to the v2 patch, except for one extra "is this pointer non-NULL?" check in do_up() - where v2 crashed. Stared a bit at the code (again), subjected to t_client and server tortu

[Openvpn-devel] OpenVPN 3 Linux client - v15 beta released

Hi, The OpenVPN 3 Linux v15 (beta) is now available. This is primarily a bugfix release as a few issues appeared soon after the last release. * Bugfix: 2FA authentication with dynamic challenge protocol Servers (most commonly OpenVPN Access Server) deployed with 2FA based authentication w

Re: [Openvpn-devel] RfD: Windows code, UNICODE and ansi

Hi, On Sun, May 30, 2021 at 04:12:37PM -0400, Selva Nair wrote: > > So my "vote" would be towards what you propose - always build unicode, > > and for older code, assume (or force-#define) UNICODE. > > > > Plus, document this somewhere. On our styleguide page, maybe? > > I have added a section n