[Openvpn-devel] [PATCH applied] Re: t_client.sh: correctly report all failed instances in summary

2020-07-03 Thread Gert Doering
Patch has been applied to the master branch. commit ec33bae311e7f3549b05de4a4c92fa7bc7144d29 Author: Gert Doering Date: Fri Jun 26 10:27:43 2020 +0200 t_client.sh: correctly report all failed instances in summary Signed-off-by: Gert Doering Acked-by: Antonio Quartulli Mes

[Openvpn-devel] [PATCH] tap.c: fix adapter renaming

2020-07-03 Thread Lev Stipakov
From: Lev Stipakov Turns out that renaming adapter by setting registry key doesn't really work - while new adapter name is shown in control panel etc, when one tries to change adapter properties (like set DNS) with netsh call - it fails: Fri Mar 13 09:05:36 2020 us=569311 Setting IPv4 dns server

Re: [Openvpn-devel] [PATCH] t_client.sh: correctly report all failed instances in summary

2020-07-03 Thread Gert Doering
Hi, On Fri, Jul 03, 2020 at 07:11:04PM +0200, Antonio Quartulli wrote: > On 26/06/2020 10:27, Gert Doering wrote: > > t_client.sh reports a summary at the end: > > > > Test sets succeeded: none. > > Test sets failed: 1 2 3 4 5. [..] > I can't easily come up with a t_client instance that verif

Re: [Openvpn-devel] [PATCH] t_client.sh: correctly report all failed instances in summary

2020-07-03 Thread Antonio Quartulli
Hi, On 26/06/2020 10:27, Gert Doering wrote: > t_client.sh reports a summary at the end: > > Test sets succeeded: none. > Test sets failed: 1 2 3 4 5. > > for tests that are skipped due to the pre-test ping check ("vpn target > IP must not ping before VPN ist started") the script forgot to a

[Openvpn-devel] [PATCH applied] Re: Remove did_open_context, defined and connection_established_flag

2020-07-03 Thread Gert Doering
Ran a full server side test (with p2p and p2mp instances), and everything *I* test still works (client-connect script, plugin-auth-pam with async-auth, *failed* plugin-auth-pam). Your patch has been applied to the master branch. commit c252dcc073155567c1982611ec6f065342909287 Author: Arne Schwab

Re: [Openvpn-devel] [PATCH] Remove did_open_context, defined and connection_established_flag

2020-07-03 Thread Antonio Quartulli
Compile tested and checked logically by going through the various places where these members were used (except for defined which is not used anywhere :-)). It all looks good and makes sense! Glad to see that we are simplifying these jungle of state variables.. On 03/07/2020 11:55, Arne Schwabe

Re: [Openvpn-devel] [RFC] Challenges with OpenVPN and configuring DNS

2020-07-03 Thread Jonathan K. Bullard
Hi. There's a lot here and I haven't digested all of it, but have a couple of comments about macOS and Tunnelblick, below. On Tue, Jun 23, 2020 at 6:57 PM David Sommerseth wrote: > > > Hi, > > Arne and I have discussed the challenge of DNS configuration and we have paid > attention to a recent di

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-07-03 Thread Jan Just Keijser
Hi, On 03/07/20 11:18, Arne Schwabe wrote: The main purpose of that RFC is to ensure we handle DNS and --dhcp-options consistently across all OpenVPN implementations we care about, and that we document this properly. I see one as an implementation issue (can we specify a particular DHCP option

[Openvpn-devel] [PATCH] Remove did_open_context, defined and connection_established_flag

2020-07-03 Thread Arne Schwabe
multi_instance->defined is not used anywhere. did_open_context is always set to true when a context is created in multi_create_instance, so checking it for true is always true. context_auth is also always set to CAS_PENDING in multi_create_instance. connection_established_flag is only set to tru

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-07-03 Thread Jonathan K. Bullard
Hi, On Fri, Jul 3, 2020 at 3:39 AM Jan Just Keijser wrote: > > Hi, > > On 02/07/20 23:04, David Sommerseth wrote: > > On 30/06/2020 16:15, Jan Just Keijser wrote: > >> hi, > >> > >> On 30/06/20 16:11, Gert Doering wrote: > >>> Hi, > >>> > >>> On Tue, Jun 30, 2020 at 04:07:52PM +0200, Jan Just Kei

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-07-03 Thread Arne Schwabe
>> The main purpose of that RFC is to ensure we handle DNS and >> --dhcp-options >> consistently across all OpenVPN implementations we care about, and >> that we >> document this properly. >> > > I see one as an implementation issue (can we specify a particular DHCP > option more than once) and o

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-07-03 Thread Jan Just Keijser
Hi, On 02/07/20 23:04, David Sommerseth wrote: On 30/06/2020 16:15, Jan Just Keijser wrote: hi, On 30/06/20 16:11, Gert Doering wrote: Hi, On Tue, Jun 30, 2020 at 04:07:52PM +0200, Jan Just Keijser wrote: @@ -5697,6 +5740,11 @@ build_dhcp_options_string(struct buffer *buf, const struct tun