Compile tested and checked logically by going through the various places
where these members were used (except for defined which is not used
anywhere :-)).

It all looks good and makes sense!


Glad to see that we are simplifying these jungle of state variables..

On 03/07/2020 11:55, Arne Schwabe wrote:
> multi_instance->defined is not used anywhere.
> 
> did_open_context is always set to true when a context is created in
> multi_create_instance, so checking it for true is always true.
> 
> context_auth is also always set to CAS_PENDING in multi_create_instance.
> 
> connection_established_flag is only set to true if context_auth
> is changed from CAS_PENDING to one another state, so we can also check
> for cas_context != CAS_PENDING.
> 
> Signed-off-by: Arne Schwabe <a...@rfc2549.org>

Acked-by: Antonio Quartulli <a...@unstable.cc>


-- 
Antonio Quartulli


_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to