Re: [Openvpn-devel] OpenVPN 2.4.9 released

2020-04-19 Thread Christian Hesse
Samuli Seppänen on Mon, 2020/04/20 09:13: > On a related note: I think we should consider stopping the distribution > of the security list's public key from our webservers and just instruct > people to fetch the key from the keyservers and refresh it if they have > trouble. Key server operation b

Re: [Openvpn-devel] OpenVPN 2.4.9 released

2020-04-19 Thread Samuli Seppänen
Hi, Il 19/04/20 13:03, Gert Doering ha scritto: > Hi, > > On Sat, Apr 18, 2020 at 02:30:46PM +0200, Simon Matter wrote: >> A long time ago I was asking them to also show MD5/SHAXXX checksums so I >> can easily verify the downloads. My request was turned down for reasons I >> still don't understan

Re: [Openvpn-devel] [PATCH v2 3/3] After the last big formatting patch a number of changes have been commited that do not conform with our style/uncrustify config. This has lead to the problem that ru

2020-04-19 Thread Gert Doering
Hi, On Sun, Apr 19, 2020 at 02:22:37PM +0200, Antonio Quartulli wrote: > >>> -char* ret = management_query_multiline_flatten(man, > >>> -(char *)buf_bptr(&buf_data), prompt, desc, > >>> -&man->connection.ext_key_state, > >>> &man->connection.ext_key_input); > >>> +

Re: [Openvpn-devel] [PATCH v2 3/3] After the last big formatting patch a number of changes have been commited that do not conform with our style/uncrustify config. This has lead to the problem that ru

2020-04-19 Thread Antonio Quartulli
Hi, On 19/04/2020 12:27, Gert Doering wrote: > Hi, > > On Fri, Apr 17, 2020 at 05:01:29PM +0200, Antonio Quartulli wrote: >>> -char* ret = management_query_multiline_flatten(man, >>> -(char *)buf_bptr(&buf_data), prompt, desc, >>> -&man->connection.ext_key_state, >>>

[Openvpn-devel] [PATCH applied] Re: After the last big formatting patch a number of changes have been commited that do not conform with our style/uncrustify config. This has lead to the problem that r

2020-04-19 Thread Gert Doering
Acked-by: Gert Doering Verified the changes manually and by test compiling (Linux and FreeBSD) - with "git show -w" one can see that most of it is simple whitespace changes, and the rest is "change line wraps" and "add comment to #endif" stuff. The manage.c change is particularily ugly, but with

[Openvpn-devel] [PATCH applied] Re: Minor style change to improve code style

2020-04-19 Thread Gert Doering
Your patch has been applied to the master branch. (And yes...) commit cbde07f474ae9e92b329475767c4660dd35b4ee4 Author: Arne Schwabe Date: Thu Apr 16 13:39:29 2020 +0200 Minor style change to improve code style Signed-off-by: Arne Schwabe Acked-by: Antonio Quartulli Messa

Re: [Openvpn-devel] [PATCH v2 3/3] After the last big formatting patch a number of changes have been commited that do not conform with our style/uncrustify config. This has lead to the problem that ru

2020-04-19 Thread Gert Doering
Hi, On Fri, Apr 17, 2020 at 05:01:29PM +0200, Antonio Quartulli wrote: > > -char* ret = management_query_multiline_flatten(man, > > -(char *)buf_bptr(&buf_data), prompt, desc, > > -&man->connection.ext_key_state, > > &man->connection.ext_key_input); > > +char *ret

[Openvpn-devel] [PATCH applied] Re: Refactor counting number of element in a : delimited list into function

2020-04-19 Thread Gert Doering
Your patch has been applied to the master branch. Nothing to add to Antonio's review :) commit c577facffb09046da90c52f3ed1af5bdf7b25888 Author: Arne Schwabe Date: Thu Apr 16 17:26:18 2020 +0200 Refactor counting number of element in a : delimited list into function Signed-off-by: Ar

[Openvpn-devel] [PATCH applied] Re: t_net.sh: use dummy interface instead of tun

2020-04-19 Thread Gert Doering
Acked-by: Gert Doering Your patch has been applied to the master branch. commit d8225e98f23d1f133b914bd63c90c8113c713fc7 Author: Antonio Quartulli Date: Thu Apr 16 15:49:25 2020 +0200 t_net.sh: use dummy interface instead of tun Signed-off-by: Antonio Quartulli Acked-by: Gert

[Openvpn-devel] [PATCH applied] Re: sitnl: fix ignoring EEXIST when sending a netlink command

2020-04-19 Thread Gert Doering
Acked-by: Gert Doering Proper error handling is hard, we should just always crash with ASSERT() :-) Your patch has been applied to the master branch. commit db3d737ba3ef9d83c5ceffa2f653d0ee4a8abb54 Author: Antonio Quartulli Date: Sat Apr 18 11:43:50 2020 +0200 sitnl: fix ignoring EEXIST

Re: [Openvpn-devel] OpenVPN 2.4.9 released

2020-04-19 Thread Gert Doering
Hi, On Sat, Apr 18, 2020 at 02:30:46PM +0200, Simon Matter wrote: > A long time ago I was asking them to also show MD5/SHAXXX checksums so I > can easily verify the downloads. My request was turned down for reasons I > still don't understand. At least it could give us some peace of mind when > dow

[Openvpn-devel] [PATCH applied] Re: sitnl: fix TUN/TAP confusion in error messages

2020-04-19 Thread Gert Doering
Acked-by: Gert Doering Yeah, "is_tun_p2p()" has always been misleading... one could argue for "can't add IP to *p2p* interface..." vs "*network* interface" (or something like that), but then, it's not really adding that much extra value. Out it goes. Your patch has been applied to the master

[Openvpn-devel] [PATCH applied] Re: sitnl: fix failure reporting by keeping error negative

2020-04-19 Thread Gert Doering
Acked-by: Gert Doering "Does what it says on the tin, and makes sense". Your patch has been applied to the master branch. commit 74fadcf4ebe860c15d12cb4e065c7ca0e0dc4497 Author: Antonio Quartulli Date: Sat Apr 18 03:18:49 2020 +0200 sitnl: fix failure reporting by keeping error negative