Acked-by: Gert Doering <g...@greenie.muc.de> Verified the changes manually and by test compiling (Linux and FreeBSD) - with "git show -w" one can see that most of it is simple whitespace changes, and the rest is "change line wraps" and "add comment to #endif" stuff.
The manage.c change is particularily ugly, but with a function name that long and multiple (long) arguments, there is not really a way that an automated tool can make this look *nice* (except if it had a rule for "if the indended indent is > 50 chars, limit to 50" or so - but then it would just be inconsistent). Your patch has been applied to the master branch. I've modified the commit message slightly (put the long text in the body, add a shorter subject) commit 9cf7b4925a54d93fbea1cadcf3dc0e11f3ce358f Author: Arne Schwabe Date: Thu Apr 16 13:39:30 2020 +0200 Another round of uncrustify code cleanup. After the last big formatting patch a number of changes have been commited that do not conform with our style/uncrustify config. This has lead to the problem that running uncrustify on before sending PR some of the changes made by uncrustify need to be backed out again. Signed-off-by: Arne Schwabe <a...@rfc2549.org> Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <20200416113930.15192-3-a...@rfc2549.org> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg19750.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel