Re: [Openvpn-devel] multihome broken in the presence of asymmetric routing

Am 12.03.18 um 11:37 schrieb Teodor Milkov: > Hello, > > I have the following multihomed setup: > > >    BGP1    BGP2 >     ^   ^ >     |   | > +---+---+    +--+---+ > | IP

Re: [Openvpn-devel] [PATCH v2 3/5] Move NCP related function into a seperate file and add unit tests

I found this discussion https://sourceforge.net/p/openvpn/mailman/message/34405489/ and wonder if we should replace strdup with string_alloc("AES-256-GCM"). If the result of strdup is NULL because of OOM, then following is NULL char *peer_ncp_list = tls_peer_ncp_list(peer_info); and it is

Re: [Openvpn-devel] [PATCH v2 3/5] Move NCP related function into a seperate file and add unit tests

Am 14.02.20 um 14:08 schrieb Lev Stipakov: > Hi, > > > > I was planning to send a separate patch, but since you moved > this code, maybe you could fix it here. > >> +bool >> +tls_item_in_cipher_list(const char *item, const char *list) >> +{ >> +    char *tmp_ciphers = string_alloc(list, NULL);

Re: [Openvpn-devel] [PATCH v2 2/5] Implement dynamic NCP negotiation

Am 14.02.20 um 13:23 schrieb Lev Stipakov: > Hi, > > to 13. helmik. 2020 klo 15.51 Arne Schwabe (a...@rfc2549.org > ) kirjoitti: >> >> Our current NCP version is flawed in the way that it can only indicate > support for > > Built and tested on Ubuntu 18 and MSVC. Works as

Re: [Openvpn-devel] [PATCH v4 2/2] Add unit tests for engine keys

пт, 14 февр. 2020 г. в 18:05, James Bottomley < james.bottom...@hansenpartnership.com>: > On Thu, 2020-02-13 at 19:18 +0100, Arne Schwabe wrote: > > Am 10.02.18 um 23:50 schrieb James Bottomley: > > > Testing engines is problematic, so one of the prerequisites built > > > for the tests is a simple

Re: [Openvpn-devel] [PATCH v2 4/5] Normalise ncp-ciphers option and restrict it to 127 bytes

Hi, > > + > +#idef ENABLE_CRYPTO_OPENSSL Boom. ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH v2 3/5] Move NCP related function into a seperate file and add unit tests

Hi, I was planning to send a separate patch, but since you moved this code, maybe you could fix it here. > +bool > +tls_item_in_cipher_list(const char *item, const char *list) > +{ > +char *tmp_ciphers = string_alloc(list, NULL); > +char *tmp_ciphers_orig = tmp_ciphers; This is redunda

Re: [Openvpn-devel] [PATCH v4 2/2] Add unit tests for engine keys

On Thu, 2020-02-13 at 19:18 +0100, Arne Schwabe wrote: > Am 10.02.18 um 23:50 schrieb James Bottomley: > > Testing engines is problematic, so one of the prerequisites built > > for the tests is a simple openssl engine that reads a non-standard > > PEM guarded key. The test is simply can we run a c

Re: [Openvpn-devel] [PATCH v2 2/5] Implement dynamic NCP negotiation

Hi, to 13. helmik. 2020 klo 15.51 Arne Schwabe (a...@rfc2549.org) kirjoitti: > > Our current NCP version is flawed in the way that it can only indicate support for Built and tested on Ubuntu 18 and MSVC. Works as advertised. Out of curiosity - you picked strsep because strtok which we have used