Am 14.02.20 um 14:08 schrieb Lev Stipakov:
> Hi,
>
> <skip>
>
> I was planning to send a separate patch, but since you moved
> this code, maybe you could fix it here.
>
>> +bool
>> +tls_item_in_cipher_list(const char *item, const char *list)
>> +{
>> + char *tmp_ciphers = string_alloc(list, NULL);
>> + char *tmp_ciphers_orig = tmp_ciphers;
>
> This is redundant. strtok() manipulates string, but doesn't modify pointer,
> unlike strsep. So it should be safe to to call
> This patch is just moving code that it does not touch. The original code is from Steffan. If we fix it, that should go into a different patch I think. But yes you are correct. But the compiler will optimise that away I think :) Arne
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
