Re: [Openvpn-devel] OpenVPN 2.4.8 released

2019-11-03 Thread Ton van Vliet
Hi Simon, Thanks for the additional tips. I already replied to Samuli yesterday, but only now noticed that I did not reply to the list. I did play around with pnputil (Samuli is using it in his script as well), but was not able to remove all drivers with it: some were 'in use', while others

Re: [Openvpn-devel] OpenVPN 2.4.8 released

2019-11-03 Thread Ton van Vliet
I noticed that my last reply was not sent to the mailing list, so this is a duplicate of the reply I sent to Samuli Seppänen Hi, Thanks for your detailed instructions! On 02-11-19 8:08, Samuli Seppänen wrote: Hi, Il 01/11/19 23:40, Ton van Vliet ha scritto: Thanks for the info. A quick rep

Re: [Openvpn-devel] [PATCH] tun/iproute2: support 31-bit ipv4 prefix (RFC 3021)

2019-11-03 Thread Tom Yan
So in master, when net_addr_v4_add is called in tun.c, which net_addr_v4_add (networking_iproute2.c or networking_sitnl.c) is actually used depends on how openvpn is built, right? I think the `if (broadcast)` condition in the one of networking_sitnl.c needs to be changed to `if (broadcast && prefi

Re: [Openvpn-devel] [PATCH] tun/iproute2: support 31-bit ipv4 prefix (RFC 3021)

2019-11-03 Thread Gert Doering
Hi, On Mon, Nov 04, 2019 at 03:54:49AM +0800, Tom Yan wrote: > While the commit message says "support" 31-bit prefix, this patch is a > bug fix by nature. Whether one can actually uses a /31 subnet for > *anything* (i.e. not just OpenVPN) pretty much depends entirely on the > platform itself. This

Re: [Openvpn-devel] [PATCH] tun/iproute2: support 31-bit ipv4 prefix (RFC 3021)

2019-11-03 Thread Tom Yan
While the commit message says "support" 31-bit prefix, this patch is a bug fix by nature. Whether one can actually uses a /31 subnet for *anything* (i.e. not just OpenVPN) pretty much depends entirely on the platform itself. This patch is needed simply because broadcast address does not "apply" in

Re: [Openvpn-devel] [PATCH] tun/iproute2: support 31-bit ipv4 prefix (RFC 3021)

2019-11-03 Thread Gert Doering
Hi, On Sun, Nov 03, 2019 at 07:24:43PM +0100, Gert Doering wrote: > I tend to NAK this, on a number of reasons - we support arbitrary > point-to-point links "since ever" if you do "topology p2p" (can be > out of the same /31, or just arbitrary addresses on both ends), so > I do not see why doing t

Re: [Openvpn-devel] [PATCH] tun/iproute2: support 31-bit ipv4 prefix (RFC 3021)

2019-11-03 Thread Gert Doering
Hi, On Sun, Nov 03, 2019 at 01:31:48PM +0800, Tom Yan wrote: > src/openvpn/tun.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) I tend to NAK this, on a number of reasons - we support arbitrary point-to-point links "since ever" if you do "topology p2p" (can be out of the same /31

Re: [Openvpn-devel] OpenVPN 2.4.8 released

2019-11-03 Thread Simon Rozman
Hi Ton, You can also use pnputil.exe (in an elevated command prompt) to check version, uninstall, and/or install TAP driver manually. The pnputil is a stock command line utility for driver management on all Windows. I advise you use pnputil to list all your installed TAP-Windows6 drivers - yes,

Re: [Openvpn-devel] [PATCH] networking/iproute2: support 31-bit ipv4 prefix (RFC 3021)

2019-11-03 Thread Tom Yan
Btw, is there a particular reason that we don't simply use "broadcast +" and let `ip` handle it? We won't even need to do the prefix length check if we aren't setting the broadcast address explicitly. Regards, On Sun, 3 Nov 2019 at 19:32, Tom Yan wrote: > > Hello Antonio, > > With 31-bit IPv4 pr

Re: [Openvpn-devel] [PATCH] networking/iproute2: support 31-bit ipv4 prefix (RFC 3021)

2019-11-03 Thread Tom Yan
Hello Antonio, With 31-bit IPv4 prefix, only two addresses can be provided with the single host bit. Neither the network address nor the broadcast address makes sense anymore in such "subnet", as it's basically for point-to-point link. Assigning such address with a broadcast address will prevent i

Re: [Openvpn-devel] [PATCH] travis: add Visual Studio build

2019-11-03 Thread Lev Stipakov
Hi, Please note, that in order this to work, following patches have to be > merged: > > - https://github.com/OpenVPN/openvpn-build/pull/157 > - https://patchwork.openvpn.net/patch/867/ Since all prerequisites have been merged, this patch is good to go. Here is a link to a travis build, which

Re: [Openvpn-devel] [PATCH] networking/iproute2: support 31-bit ipv4 prefix (RFC 3021)

2019-11-03 Thread Antonio Quartulli
Hi Tom, first of all, thanks a lot for your contribution! On 03/11/2019 06:30, Tom Yan wrote: > --- > src/openvpn/networking_iproute2.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/openvpn/networking_iproute2.c > b/src/openvpn/networking_iproute2.c > index