Hi,

On Sun, Nov 03, 2019 at 01:31:48PM +0800, Tom Yan wrote:
>  src/openvpn/tun.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

I tend to NAK this, on a number of reasons - we support arbitrary
point-to-point links "since ever" if you do "topology p2p" (can be
out of the same /31, or just arbitrary addresses on both ends), so
I do not see why doing this in "topology subnet" would be beneficial.

OTOH, *if* you do it, it needs to be consistently, not just "linux/iproute"
(on linux, "sitnl" is the new gold standard), and the commit message should
explain a bit more about the "why do it this way" and "how do other 
platforms deal with it" (windows, *BSD, MacOS, etc.)

gert
-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             g...@greenie.muc.de

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to