Re: [Openvpn-devel] New OpenVPN 2.4.7 installers with tap-windows6 and other componets

2019-04-23 Thread Samuli Seppänen
Il 20/04/19 18:09, Gert Doering ha scritto: > Hi, > > On Sat, Apr 20, 2019 at 12:16:49PM +0300, Samuli Seppänen wrote: >> Here are completely untested OpenVPN 2.4.7 installers which I wanted to >> get out for testing a.s.a.p.: >> >>

Re: [Openvpn-devel] [PATCH] Set the correct mtu on windows based systems

2019-04-23 Thread Christopher Schenk
Hi, i think this is not a big issue since the mtu is only set until the system gets rebooted. So it behaves exactly like my netsh version where i specified a "store=active" in the set command. Christopher On 18/04/2019 17:47, Selva Nair wrote: Hi, Thanks for the new version. I somehow miss

Re: [Openvpn-devel] New OpenVPN 2.4.7 installers with tap-windows6 and other componets

2019-04-23 Thread Gert Doering
Hi, On Tue, Apr 23, 2019 at 11:50:28AM -0400, Selva Nair wrote: > On further tests, one issue is that tapinstall.exe now depends on > VCRUNTIME140.dll which is not present in stock Windows. Probably > that's what causes the failure. Sorry for that time bomb. Samuli found the reason today (build

Re: [Openvpn-devel] New OpenVPN 2.4.7 installers with tap-windows6 and other componets

2019-04-23 Thread Selva Nair
Hi, On Sat, Apr 20, 2019 at 5:17 AM Samuli Seppänen wrote: > > Hi all, > > Here are completely untested OpenVPN 2.4.7 installers which I wanted to > get out for testing a.s.a.p.: > > >

Re: [Openvpn-devel] openvpn with udp lost event.

2019-04-23 Thread wei wang
On Tue, Apr 23, 2019 at 7:30 PM Arne Schwabe wrote: > I agree that I missed a place in which I should cleaning up the temp > file but adding it to close_instance seem more like a workaround than a > real solution. Again describing more context would be nice here. What > exactly is this trying to

Re: [Openvpn-devel] openvpn with udp lost event.

2019-04-23 Thread Arne Schwabe
Am 23.04.19 um 05:01 schrieb wei wang: > 3. clean client connect defered ret file when close instance. > I agree that I missed a place in which I should cleaning up the temp file but adding it to close_instance seem more like a workaround than a real solution. Again describing more context would b

Re: [Openvpn-devel] openvpn with udp lost event.

2019-04-23 Thread Arne Schwabe
Am 22.04.19 um 11:34 schrieb wei wang: > And I have another question about multi_process_io_udp lost event. > Is there some problem if we change if{} else if{} to if {} if {}. > e.g.: > To be honest that code is very complicated and without a in deep review of what all the stuff is doing, it is h

Re: [Openvpn-devel] openvpn with udp lost event.

2019-04-23 Thread Arne Schwabe
Am 22.04.19 um 11:26 schrieb wei wang: > 1. When client-connect tests whether the user has written the > configuration, we should check to see if the file size is 0, not > whether the file exists. I am sorry but you need to provide a bit more context to point out why you think that change is right