Re: [Openvpn-devel] [PATCH 5/5] Detect TAP interfaces with root-enumerated hardware ID

2019-01-19 Thread Simon Rozman
Hi, > On Tue, Oct 16, 2018 at 12:26:27PM +0200, Simon Rozman wrote: > > This patch extends the TAP interface enumerating to detect the TAP > > interfaces registered using "root\tap0901" hardware ID. Before, only > > TAP interfaces with legacy "tap0901" HWID were detected by > openvpn.exe. > > > >

Re: [Openvpn-devel] [PATCH applied] Re: Introduce tapctl.exe utility and openvpnmsica.dll MSI CA

2019-01-19 Thread Simon Rozman
Hi, > (I *have* glanced over the code to see that there isn't anything that > looks "suspicious" - and of course it does not modify openvpn code, so > there is no risk for introducing remote exploits, crypto breaches, etc.) > > I found a few things I'd like to see cleaned up eventually... Thank

Re: [Openvpn-devel] [PATCH] Fix broken fragment/mssfix with NCP

2019-01-19 Thread Steffan Karger
Hi, On 12-11-18 15:16, Lev Stipakov wrote: > From: Lev Stipakov > > NCP negotiation replaces worst cast crypto overhead > with actual one in data channel frame. That frame > params are used by mssfix. > > Fragment frame still contains worst case overhead. > Because of that TCP packets are fragm

[Openvpn-devel] [PATCH v2] Fix tls-auth/crypt in connection blocks with --persist-key

2019-01-19 Thread Steffan Karger
If --persist-key was used, we would always try to pre-load the 'global' tls-auth/crypt file. That would result in using the wrong key (leading to a failed connection) or en error is there was to 'global' key: Sat Jan 19 11:09:01 2019 Cannot pre-load tls-auth keyfile ((null)) Sat Jan 19 11:09:0

[Openvpn-devel] [PATCH] Fix tls-auth/crypt in connection blocks with --persist-key

2019-01-19 Thread Steffan Karger
If --persist-key was used, we would always try to pre-load the 'global' tls-auth/crypt file. That would result in using the wrong key (leading to a failed connection) or en error is there was to 'global' key: Sat Jan 19 11:09:01 2019 Cannot pre-load tls-auth keyfile ((null)) Sat Jan 19 11:09:0