Hi,

> On Tue, Oct 16, 2018 at 12:26:27PM +0200, Simon Rozman wrote:
> > This patch extends the TAP interface enumerating to detect the TAP
> > interfaces registered using "root\tap0901" hardware ID. Before, only
> > TAP interfaces with legacy "tap0901" HWID were detected by
> openvpn.exe.
> >
> > The openvpnmsica.dll and tapctl.exe install TAP interfaces using root-
> > enumerated HWIDs, and were not detected by openvpn.exe.
> 
> I do not see a specific reason to *not* apply this patch, but I'm
> wondering if you could shed some background light on the changed
> behaviour in openvpnmsica.dll and tapctl.exe?

The tapctl.exe and openvpnmsica.dll use a simplified interface installation
compared to devcon.exe/tapinstall.exe. They assume the driver is already
installed and they don't require INF file to create a TAP interface.
However, when the interface is installed this way, Windows reports its
hardware ID as "root\\tap0901". Whereas, tapinstall.exe installed TAP
interfaces report their HWID as "tap0901". That's about the only difference
I noticed.

(Tested with driver versions 9.21.x and later.)

Rather than exploring, what causes the difference and fuelled by Microsoft's
recommendation to use root-enumerated HWIDs anyway, I proposed to extend the
openvpn.exe's TAP interface detection to accept both: "tap0901" _and_
"root\\tap0901" interfaces.

> I'm not sure if we're going to care for someone who uses a 2.5 msi
> installer to set up a TAP interface and then runs a 2.3 openvpn.exe on
> top of it and wonders why it isn't finding the TAP driver - but the
> question might come up, and I like having good answers... :-)

Suggest them to remove the TAP interface and reinstall it using
tapinstall.exe. The tapinstall.exe should still be able to install 9.22 and
later TUN interfaces.

Or even better: apply this patch to 2.4 and 2.3 branches (it's a really
minor change) and ask them to compile and use the patched version of 2.3. :)

Best regards,
Simon

Attachment: smime.p7s
Description: S/MIME cryptographic signature

_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to