Acked-by: Gert Doering
Looks reasonable (the big picture "how does the installer know if there
is a GUI in the first place? does it ask?" is missing, but I assume this
is in the WiX pieces). Test compiled on Ubuntu 16.04/mingw.
Your patch has been applied to the master branch.
commit 597972bc
Acked-by: Gert Doering
Looks reasonable. Passes compile-tests on Ubuntu 16.04/mingw.
Your patch has been applied to the master branch.
commit ec7a03ee5bf9a659d0c49bf8ea27ead08b8b84d0
Author: Simon Rozman
Date: Wed Nov 21 17:36:53 2018 +0100
Add detection of active VPN connections for M
Acked-by: Gert Doering
The explanation of "what could possibly go wrong" sounds logical, and
the code change seems to match that (... and has no obvious pitfalls).
Test compiled on ubuntu 16.04 / mingw.
I have not tested this (because I have no idea how to trigger all these
scenarios) so I trus
Acked-by: Gert Doering
"Makes sense" :-) - I have only looked at the code and built a non-debug
build (because I'm lazy) but that looked reasonable, and there is nothing
in the _DEBUG block that looks suspicious.
Your patch has been applied to the master branch.
commit 27556854a512a901dba5118ad
Acked-by: Gert Doering
"Now that was an easy one" :-)
Your patch has been applied to the master branch.
commit 49cb9f9469e993abc13d317bdcd671822b47fab6
Author: Simon Rozman
Date: Mon Nov 12 13:22:45 2018 +0100
Change C++ to C comments
Acked-by: Gert Doering
Message-Id: <2018
Acked-by: Gert Doering
We have a LGTM from Jon as well, but I'm taking this on me - because I
decided I want this in 2.4 as well. Unlikely as it may be, we *will*
have people that happen to have a tap adapter on their system and try
to run 2.4.x binaries on it... so this is long-term compatibil
Your patch has been applied to the master branch.
"LGTM" from Jon after quite some discussion. I'm not trying to understand
the intricacies of the code, just some basic sanity checking ("no chance
this will scribble over a registry entry or execute unwanted binaries
by means of an uninitialized b
Hi,
On Tue, Oct 16, 2018 at 12:26:27PM +0200, Simon Rozman wrote:
> This patch extends the TAP interface enumerating to detect the TAP
> interfaces registered using "root\tap0901" hardware ID. Before, only TAP
> interfaces with legacy "tap0901" HWID were detected by openvpn.exe.
>
> The openvpnms
Your patch has been applied to the master branch.
LGTM from Jon.
commit fc74ac1e82b6727454f12580d52cf8cf5d80e503
Author: Simon Rozman
Date: Tue Oct 16 12:26:25 2018 +0200
Define _WIN32_WINNT=_WIN32_WINNT_VISTA in MSVC
Acked-by: Jon Kunkee
Message-Id: <20181016102627.18676-3-si...@r
Your patch has been applied to the master branch.
"LGTM" from Jon (plus patch and explanation seem to make sense :-) )
commit 7d08c33cfc58eeb7286446c8d1ffd02939782332
Author: Simon Rozman
Date: Tue Oct 16 12:26:24 2018 +0200
Prevent __stdcall name mangling of MSVC
Acked-by: Jon Kunkee
Taking Jon's "this looks pretty straightforward to me" as an ACK (plus,
it really is, and Samuli has also tested this already :-) ).
Your patch has been applied to the master branch.
commit 864f95c371813a2cd07b886cdc8696cc8b732ee0
Author: Simon Rozman
Date: Tue Oct 16 12:26:23 2018 +0200
Acked-by: Gert Doering
This is not a truly formal windows code review, but I'm taking this in
as the resulting builds have been tested by various people and seem to
work well, and we have so many patches on top of this already queued that
patchwork needs to go to multipage display...
(I *have*
Hi,
I have developed a bash script to make openvpn work with obfs4. It's hosted on
github: https://github.com/HRomie/obfs4proxy-openvpn
It might be worth updating the obfuscation article article and include it:
https://community.openvpn.net/openvpn/wiki/TrafficObfuscation
Regards,
Hamy_
13 matches
Mail list logo
