Acked-by: Gert Doering <g...@greenie.muc.de>
The explanation of "what could possibly go wrong" sounds logical, and
the code change seems to match that (... and has no obvious pitfalls).
Test compiled on ubuntu 16.04 / mingw.
I have not tested this (because I have no idea how to trigger all these
scenarios) so I trust you and Tincantech to have tested the variants
(automated regression testing of this stuff is going to be interesting).
The comment lines are a bit on the long side ("<80 characters, please")
but I've seen an upcoming uncrustify patch, so I hope that will be taken
care of.
Your patch has been applied to the master branch.
commit 39c9811e7d3a509405b2986e9684a99054f25923
Author: Simon Rozman
Date: Mon Nov 12 13:22:44 2018 +0100
Delete TAP interface before the TAP driver is uninstalled
Acked-by: Gert Doering <g...@greenie.muc.de>
Message-Id: <20181112122246.13556-1-si...@rozman.si>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17906.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
